New issue
Advanced search Search tips

Issue 894328 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Misclicking in the App Launcher closes the App Launcher

Project Member Reported by calamity@chromium.org, Oct 11

Issue description

Version: ChromeOS 71.0.3576.0

When you click on black space in the app launcher, it closes the app launcher. This is annoying because I don't always click accurately so, for example, when I press the App Launcher button and want to expand to All Apps, I try to click the small arrow button (which doesn't have a very visible click target) and miss, which causes the whole app list to close.

Also, more recently (as of M71?) clicking on the space between apps in the All Apps view closes the launcher as well, so if I fatfinger between the larger app spaces, I'll also end up closing the whole app list. I think clicking the black space should do nothing. It's very disconcerting to accidentally close the app list when I misclick, and seems like a net negative for usability.
 
Cc: weidongg@chromium.org newcomer@chromium.org ginko@chromium.org
Labels: M-72
Owner: ----
Status: Available (was: Untriaged)
The first part we can improve, the second part is a regression. Thanks for reporting!
Owner: ginko@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
I'm going to talk to Sebastian tomorrow about expanding the click zone for opening the launcher, so that we can look into addressing #1.

I am implementing a fix for #2 right now!
CL open for #2, will hold off on marking closed till I talk with Sebastian
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa8ff7ec167eece5ddb49b57cc02f1b17597a5e

commit 4fa8ff7ec167eece5ddb49b57cc02f1b17597a5e
Author: Kevin Strohbehn <ginko@google.com>
Date: Wed Oct 31 23:13:13 2018

Handles mouse clicks between apps in apps grid, preventing app_list close

Bug:  894328 
Change-Id: Ia12904740ef4f57643233d26710c704908cca1c8
Reviewed-on: https://chromium-review.googlesource.com/c/1309420
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#604435}
[modify] https://crrev.com/4fa8ff7ec167eece5ddb49b57cc02f1b17597a5e/ash/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/4fa8ff7ec167eece5ddb49b57cc02f1b17597a5e/ash/app_list/views/apps_grid_view.h

Cc: shibasheikh@chromium.org
Fix for #2 landed.

I'm going to experiment with possible changes to the touch region for opening the app list from peeking, though I am most in favor of simply opening the app list from peeking to full whenever we receive a tap/click, considering the intentions when clicking the app list in peeking are likely different from the intentions when it is open.
By the way, calamity@, I have had the same issue myself and my quick-fix for it is a mouse-wheel-down over the peeking launcher at any spot

The fix will probably take a little longer to look over and make a decision on
@ginko: Thanks! That's a reasonable workaround.
Status: Closed (was: Started)
Closing for fix #2, opening a new bug at https://crbug.com/906858 for issue #1

Sign in to add a comment