New issue
Advanced search Search tips

Issue 894320 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 872796

Blocking:
issue 880671



Sign in to add a comment

SuperSize: Be able to show Apk Size vs Install Size in HTML viewer

Project Member Reported by agrieve@chromium.org, Oct 11

Issue description

Currently, the sum of symbol .pss doesn't map to either of these metrics!

In order to get there, we need to:
* Add symbols for any bytes not currently accounted for (bug 872796)
* Record compression metadata in .size files


Some thoughts on how to add this:
* Compression metadata can be stored in the key/value metadata.
* When viewing diffs, We'll need to synthesize symbols to represent compression differences (just like we do for padding differences via "accumulated padding")
* It doesn't make sense to store compressed sizes on a granularity smaller than an entire file
  * e.g. store "dex_compression_ratio" as sum(compressed_size_of_all_dex_files) / sum(uncompressed_size_of_all_dex_files).
  * And do the same for locale pak files.

Per-symbol size should never have compression applied to it within the file format, nor during diffs, but we can add logic to the HTML (and console?) UI to apply the ratio during presentation.


Show APK Size:
 * Apply compression ratio to all relevant symbols

Show Installed APK Size:
 * Apply compression ratio to all relevant symbols, and also adjust the ratio based on the symbol type (e.g. dex gets extracted, so add 1 to the ratio).
   * Refer to resource_sizes.py for what the install multipliers should be.



Note: It may be nice to have supersize show "Normalized Apk Size" as well, but I don't think the complexity is worth it for the string logic behind it. Moreso, bundles will make tracking strings far less important.
 
Owner: hua...@chromium.org
Status: Assigned (was: Available)
Blocking: 880671

Sign in to add a comment