New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894305 link

Starred by 1 user
Status: Fixed
Owner:
█ jhawkins@chromium.org
Last visit > 30 days ago
Closed: Oct 29
Cc:
█ jlklein@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Write tests for Smart Lock settings subpage

Project Member Reported by jhawkins@chromium.org, Oct 11 
Per some of the suggestions in crrev.com/c/1274890 and just generally get good coverage.

Comment 1 by jhawkins@chromium.org, Oct 11 

Same for crrev.com/c/1275142.

Comment 2 by hansberry@chromium.org, Oct 11

Cc: jlklein@chromium.org jordynass@chromium.org nohle@chromium.org jhawkins@chromium.org hansberry@chromium.org

Comment 3 by jhawkins@chromium.org, Oct 25

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b13ee619fbf8ef10e74840a414b81a6b41120add

commit b13ee619fbf8ef10e74840a414b81a6b41120add
Author: James Hawkins <jhawkins@chromium.org>
Date: Sat Oct 27 01:07:44 2018

Smart Lock: Add tests for the settings implementation.

Bug:  894305 
Test: CrSettingsMultideviceSmartLockSubpageTest.*

R=khorimoto@chromium.org

Change-Id: Iecad14608d51137c35e9aa7875b0078ee41c541b
Reviewed-on: https://chromium-review.googlesource.com/c/1299604
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603281}
[modify] https://crrev.com/b13ee619fbf8ef10e74840a414b81a6b41120add/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/b13ee619fbf8ef10e74840a414b81a6b41120add/chrome/test/data/webui/settings/multidevice_smartlock_subpage_test.js
[modify] https://crrev.com/b13ee619fbf8ef10e74840a414b81a6b41120add/chrome/test/data/webui/settings/test_multidevice_browser_proxy.js

Comment 5 by jhawkins@chromium.org, Oct 29

Status: Fixed (was: Started)
►

Sign in to add a comment