New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894284 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add an option to stop the Crostini VM in the Terminal's shelf context menu

Project Member Reported by rjwright@chromium.org, Oct 11

Issue description

Currently there is an option to stop the Crostini VM in the context menu of the Terminal app-list item. We should add the same in the shelf.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e6bcceca05f4026d01b870a823dd4140c525e9

commit 64e6bcceca05f4026d01b870a823dd4140c525e9
Author: Renee Wright <rjwright@chromium.org>
Date: Thu Oct 11 22:58:45 2018

Add Stop-VM to Terminal shelf context menu

We want users to be able to stop the entire Termina VM via the shelf
icon context menu for the (Crostini) Terminal. This is already possible
via the app list.

To achieve this I needed to add a new CommandID, as menu_close was
already used. This does not seem ideal, however there is a chance
that this command will be useful for other VMs later.

Bug:  894284 
Change-Id: I8bd91e431f9260766b3297b575ce9c8968c09b83
Reviewed-on: https://chromium-review.googlesource.com/c/1267056
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598995}
[modify] https://crrev.com/64e6bcceca05f4026d01b870a823dd4140c525e9/ash/public/cpp/app_menu_constants.h
[modify] https://crrev.com/64e6bcceca05f4026d01b870a823dd4140c525e9/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc
[modify] https://crrev.com/64e6bcceca05f4026d01b870a823dd4140c525e9/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc

Status: Fixed (was: Started)

Sign in to add a comment