New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894276 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

XCURSOR_SIZE isn't always set correctly

Project Member Reported by jkardatzke@chromium.org, Oct 10

Issue description

Now that we run 2 instances of sommelier, it is a race for which one ends up exporting XCURSOR_SIZE to the environment. This affects some applications such as VSCode and emacs who will then have tiny cursors if the one with the smaller cursor size wins the race.

This'll need to be fixed in the startup scripts and the daemons that will be launching apps in 'scaled' mode too.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/e6d7fd369cba63fa739900946f8ca7fb5617f911

commit e6d7fd369cba63fa739900946f8ca7fb5617f911
Author: Tim Zheng <timzheng@google.com>
Date: Fri Oct 12 04:34:43 2018

Add environment variable XCURSOR_SIZE_LOW_DENSITY.

Now that we have a high density and a low density instances of X
Sommelier, we need to have seperate environment variables for the
XCURSOR_SIZE.

BUG= chromium:894276 
TEST=Manually tested on an eve device.

Change-Id: Ie07a784cc7805a00de164c9a5738fdcae8db9c5a
Reviewed-on: https://chromium-review.googlesource.com/1275086
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/e6d7fd369cba63fa739900946f8ca7fb5617f911/cros-sommelier/sommelier-x@.service
[modify] https://crrev.com/e6d7fd369cba63fa739900946f8ca7fb5617f911/cros-sommelier-config/cros-sommelier-low-density-override.conf
[modify] https://crrev.com/e6d7fd369cba63fa739900946f8ca7fb5617f911/cros-sommelier/BUILD
[modify] https://crrev.com/e6d7fd369cba63fa739900946f8ca7fb5617f911/cros-sommelier-config/BUILD
[modify] https://crrev.com/e6d7fd369cba63fa739900946f8ca7fb5617f911/cros-sommelier/sommelier.sh

Status: Fixed (was: Started)

Sign in to add a comment