The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9268d9a11d1d967f5a090f5411f7ed041192b561

commit 9268d9a11d1d967f5a090f5411f7ed041192b561
Author: Luum Habtemariam <luum@chromium.org>
Date: Mon Oct 29 22:43:12 2018

Added overloaded base::SplitStringIntoKeyValuePairs

Allowed key_value_pair_delimeter to be any arbitrary substring rather
than limited to just a char. Functionality of current function upheld
and rewritten in terms of the new, more general one.

Test: Current and newly added tests pass
Bug:  chromium:894274 
Change-Id: I6b487dfeb0c4a38e94526f3931d15c8e1b83db66
Reviewed-on: https://chromium-review.googlesource.com/c/1302498
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603668}
[modify] https://crrev.com/9268d9a11d1d967f5a090f5411f7ed041192b561/base/strings/string_split.cc
[modify] https://crrev.com/9268d9a11d1d967f5a090f5411f7ed041192b561/base/strings/string_split.h
[modify] https://crrev.com/9268d9a11d1d967f5a090f5411f7ed041192b561/base/strings/string_split_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de04887a2fb977f433502e9485176d94e8f918d3

commit de04887a2fb977f433502e9485176d94e8f918d3
Author: Luum Habtemariam <luum@chromium.org>
Date: Wed Oct 31 08:28:23 2018

Re-add deleted base::StringSplitIntoKeyValuePairs unittest

Re-adds the MissingKeyValueDelimiter unittest, accidentally removed in
commit 9268d9a11d1d967f5a090f5411f7ed041192b561.

Bug:  chromium:894274 
Test: Tests still pass.
Change-Id: I37228e812eaf71b1d51fb9982aedea70570311d2
Reviewed-on: https://chromium-review.googlesource.com/c/1306657
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604185}
[modify] https://crrev.com/de04887a2fb977f433502e9485176d94e8f918d3/base/strings/string_split_unittest.cc