Enable CRTC background color property for Intel GEN9+ graphics
Reported by
wei.c...@intel.com,
Oct 10
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: N/A What is the expected behavior? What went wrong? Intel GEN9+ graphics HW supports a programmable CRTC background color property, however, the property is not exposed by kernel and cannot be used in user space for now. Basically, the CRTC background color can show up anywhere that isn’t covered by a plane, the compositor can utilize the background/canvas color to create UIs, or use it and turn off primary plane in some full-screen cases to save power, so we might need to work out to expose the CRTC background color property, and add applications in user-space. Did this work before? N/A Chrome version: 69.0.3497.95 Channel: stable OS Version: Flash Version:
,
Oct 31
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/c27f522e3efde1754afb9d149d95a750fe34f465 commit c27f522e3efde1754afb9d149d95a750fe34f465 Author: Wei Li <wei.c.li@intel.com> Date: Fri Jan 11 17:48:03 2019 Add CRTC background color test This CL adds |background_color| property to crtcs and a test to check that the property works as expected: we can get the property value, and set the value to change the background color of crtcs. BUG=chromium:894259 TEST=atomictest -t crtc_background_color Change-Id: I30fe445d533760bd0280df650445deb4d2617b5f Reviewed-on: https://chromium-review.googlesource.com/1241436 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Wei Li <wei.c.li@intel.com> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> [modify] https://crrev.com/c27f522e3efde1754afb9d149d95a750fe34f465/atomictest.c
,
Today
(17 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/391aecb03754183fd111e7b671881ea704b23987 commit 391aecb03754183fd111e7b671881ea704b23987 Author: Wei Li <wei.c.li@intel.com> Date: Tue Jan 22 15:14:32 2019 Add CRTC background color property and methods to get & set it Intel GEN9+ platforms support a programmable CRTC background color below HW planes. The background color can be seen on areas not covered by the planes. This CL adds the background color property exposed by kernel, and the methods to get & set the property. BUG=chromium:894259 Change-Id: I2f43eb91e76f8d7f22faa0c75de553a066f8fdee Reviewed-on: https://chromium-review.googlesource.com/c/1278858 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> Auto-Submit: Wei Li <wei.c.li@intel.com> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#624781} [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/AUTHORS [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/drm_display.cc [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/drm_display.h [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc [modify] https://crrev.com/391aecb03754183fd111e7b671881ea704b23987/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by tbuckley@google.com
, Oct 12