Supporting Telemetry-based GPU tests in FindIt - support Findit required cmd flags |
|||||
Issue description
To support telemetry-based tests in Findit, test runners need to support the following cmd flags:
1. --isolated-script-test-filter=A::B::C
2. --isolated-script-test-repeat=30
a. To be consistent with currently supported test types, the exec
order should be ABCABCABC...
3. --isolated-script-test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests
Context: https://docs.google.com/document/d/1XZrAecLT33sJng9JTHsWCNpcBVU_BT7weLE76nwsTXA/edit?usp=sharing
,
Oct 10
--isolated-script-test-filter is already supported. The other ones need to be implemented. --isolated-script-test-repeat and --isolated-script-test-launcher-retry-limit will have to be passed down through Telemetry to the typ harness. --isolated-script-test-also-run-disabled-tests will be handled at the GPU test layer, by ignoring test expectations.
,
Oct 29
Hello kbr@, I want to follow up on this and check when will you have cycle on this change? Or are you blocked on any other things?
,
Oct 29
Thanks for reminding me. Let me see whether the fix for Issue 894261 added all of the needed primitives to typ that the GPU tests need.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2dac9b8e2147df82cd743c6c9ade4f126403d9f commit b2dac9b8e2147df82cd743c6c9ade4f126403d9f Author: Kenneth Russell <kbr@chromium.org> Date: Fri Nov 02 00:03:36 2018 Support FindIt's command line arguments in Chrome GPU tests. Add support for the --isolated-script-test-repeat, --isolated-script-test-launcher-retry-limit and --isolated-script-test-also-run-disabled-tests flags, and unit tests for these flags' behavior. Bug: 894258 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I82cf1638779719b55b8b016c323100de572aae46 Reviewed-on: https://chromium-review.googlesource.com/c/1306662 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604763} [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/context_lost_integration_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/gpu_integration_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/gpu_integration_test_unittest.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/info_collection_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/power_measurement_integration_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/screenshot_sync_integration_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/content/test/gpu/unittest_data/integration_tests.py [modify] https://crrev.com/b2dac9b8e2147df82cd743c6c9ade4f126403d9f/testing/scripts/run_gpu_integration_test_as_googletest.py
,
Nov 2
This should be working now. Please reopen or file a new bug and link to this one if not. Thanks.
,
Nov 8
Forgot to actually close the bug.
,
Dec 20
,
Dec 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by chanli@chromium.org
, Oct 10