Issue metadata
Sign in to add a comment
|
Enable/Disable docked magnifier when overview is enabled should change the work area |
||||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3577.0 What steps will reproduce the problem? (1)Enable dock magnifier. (2)Tap overview button to enter overview mode. or (1)Tap overview button to enter overview mode. (2)Enable dock magnifier. What is the expected result? The work area should be updated based on enable/disable dock magnifier. What happens instead? No change of the work area. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Oct 11
,
Oct 11
,
Oct 11
This is because we explicitly ignore updating the display's work area when overview mode is enabled: See https://chromium-review.googlesource.com/c/chromium/src/+/1140749. Oshima-san's recommendation is to exit overview mode whenever we change the status of the docked magnifier. I think this is reasonable. +lpalmaro@ what do you think?
,
Oct 11
I think that's reasonable!
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7add41457f5e261383e2fe58322392ce5fd03247 commit 7add41457f5e261383e2fe58322392ce5fd03247 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Fri Oct 12 18:15:49 2018 Exit overview mode when toggling the docked magnifier Changing the Display's work area is not allowed while overview mode is active, but the docked magnifier need to update the display's work area. As a result we should exit the overview mode before toggling the docked magnifier. BUG= 894256 TEST=Added new ash_unittests Change-Id: Id1776bb814aa6dc7cbdc338575b9c8fdc02ab69d Reviewed-on: https://chromium-review.googlesource.com/c/1278473 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599294} [modify] https://crrev.com/7add41457f5e261383e2fe58322392ce5fd03247/ash/magnifier/docked_magnifier_controller.cc [modify] https://crrev.com/7add41457f5e261383e2fe58322392ce5fd03247/ash/magnifier/docked_magnifier_controller.h [modify] https://crrev.com/7add41457f5e261383e2fe58322392ce5fd03247/ash/magnifier/docked_magnifier_controller_unittest.cc
,
Oct 12
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by minch@chromium.org
, Oct 10