New issue
Advanced search Search tips

Issue 894243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The parameter for utilizing stationary signal properties in WebRTC AEC3 is overridden by default

Project Member Reported by peah@chromium.org, Oct 10

Issue description

Chrome overrides the parameter for utilizing stationary signal properties in WebRTC AEC3 unless a command line parameter is explicitly used to activate it. That is not the desired behavior and should be corrected.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d6b079686f7803bde1396cc7ef7719fe891cfe0e

commit d6b079686f7803bde1396cc7ef7719fe891cfe0e
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Oct 11 08:10:18 2018

AEC3: Ensure that the usage of stationary signal properties is not unset

This CL ensures that the default setting for the usage of stationary signal
properties is not overridden by mistake.

Bug:  chromium:894243 
Change-Id: I85ab65383ee82b5f3153864da7a0cede7776c146
Reviewed-on: https://webrtc-review.googlesource.com/c/105181
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25104}
[modify] https://crrev.com/d6b079686f7803bde1396cc7ef7719fe891cfe0e/modules/audio_processing/aec3/echo_canceller3.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79ac5dee8cac6a7e0359817371f3e4a6fa812f9

commit a79ac5dee8cac6a7e0359817371f3e4a6fa812f9
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 11 13:55:10 2018

Roll src/third_party/webrtc e8d2b1be1a7c..2b1562632a02 (11 commits)

https://webrtc.googlesource.com/src.git/+log/e8d2b1be1a7c..2b1562632a02


git log e8d2b1be1a7c..2b1562632a02 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 henrikg@webrtc.org Revert "Use unique_ptr and ArrayView in SSLFingerprint"
2018-10-11 saza@webrtc.org Don't CHECK when parsing AEC3 parameters from json
2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2499289737..f34485ffde (598606:598711)
2018-10-11 danilchap@webrtc.org Use zero octets for rtp packet padding
2018-10-11 mbonadei@webrtc.org Reland "Export symbols needed by the Chromium component build (part 1)."
2018-10-11 sprang@webrtc.org Add ability to specify if rate controller of video encoder is trusted.
2018-10-11 nisse@webrtc.org Delete post_encode_callback
2018-10-11 peah@webrtc.org AEC3: Cleanup test code for platforms with clock-drift
2018-10-11 peah@webrtc.org AEC3: Ensure that the usage of stationary signal properties is not unset
2018-10-11 ilnik@webrtc.org Remove unlimited retransmission for screenshare experiment code
2018-10-11 steveanton@webrtc.org Use unique_ptr and ArrayView in SSLFingerprint


Created with:
  gclient setdep -r src/third_party/webrtc@2b1562632a02

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:894243
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id36980209394996021f7bdff0bff127b39af7407
Reviewed-on: https://chromium-review.googlesource.com/c/1275876
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598747}
[modify] https://crrev.com/a79ac5dee8cac6a7e0359817371f3e4a6fa812f9/DEPS

Status: Assigned (was: Untriaged)
Assigning these all to you, since it looks like you reported them and they're about AEC3. Untriaged needs to get triaged. :)
Is this finished?
Status: Fixed (was: Assigned)

Sign in to add a comment