App icon does not show correctly |
||||||||
Issue descriptionChrome Version: 71.0.3577.0 OS: Chrome What steps will reproduce the problem? Not sure exactly which step caused this problem. It looks like Chrome crashed at some point, and then had this problem. Once it happened, it persisted in laptop mode and tablet mode. And reboot can't fix it. What is the expected result? App icons should show correctly in shelf/launcher What happens instead? See screenshots. Also, please take a look at the screenshot, the rounded corner of the shelf doesn't look right. One side of the shelf has rounded corner, while the other doesn't. weidongg@, do you know who should be the right owner?
,
Oct 10
There's a change this morning fixed the issue in ImageView, I will mark this as duplicate. If it occurs again, please feel free to reopen it.
,
Oct 10
Did the change land yet? Actually I sync'ed about 1 hour ago and got this issue.
,
Oct 10
In that case, it might still exist.
,
Oct 10
+malaykeshav@
,
Oct 11
I thought this was associated with the bug in ImageView, but if it is persisting even after sync with ToT, then it may be a different issue. This is the change that fixed the ImageView issue: https://chromium.googlesource.com/chromium/src/+/5b98be91d96f0b653bafce146c9d1f036a34b688
,
Oct 11
After bisecting, found the culprit CL: https://chromium-review.googlesource.com/c/1271784
,
Oct 11
A few context for app item in app list: We show two icon for each item, one with shadow and the other without shadow. (The icon with shadow has larger bounds, we only expose the icon without shadow to outside the class for simplicity of calculating icon bounds.) They overlap with each other to look like a single icon with shadow.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6db8452d24b72cdb41e995003fbda88f244d9600 commit 6db8452d24b72cdb41e995003fbda88f244d9600 Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Oct 11 01:16:20 2018 Minor bugfix to add a missing call to the parnet funciton A call to the parent OnBoundsChanged function is missing which results in the image origin not being updated. Bug: 894242 Change-Id: I7f7f911f066a0470b58232af3b37ea088712a5cf Component: App list icon Reviewed-on: https://chromium-review.googlesource.com/c/1275141 Reviewed-by: Weidong Guo <weidongg@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#598613} [modify] https://crrev.com/6db8452d24b72cdb41e995003fbda88f244d9600/ash/app_list/views/app_list_item_view.cc
,
Oct 11
,
Oct 11
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 22
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by weidongg@chromium.org
, Oct 10