New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894226 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Oct 11
Cc:
█ servolk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Teach webm_colour_parser.cc to use libwebm definitions

Project Member Reported by mcasas@chromium.org, Oct 10 
media/formats/webm/webm_colour_parser.cc copy-pastes definitions
from libwebm; instead, just include the file.  The code says that:

// The definitions below are copied from the current libwebm top-of-tree.
// Chromium's third_party/libwebm doesn't have these yet. We can probably just
// include libwebm header directly in the future.
// ---- Begin copy/paste from libwebm/webm_parser/include/webm/dom_types.h ----
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281cab6e153d01a5133cb73c3d334f759b1eef65

commit 281cab6e153d01a5133cb73c3d334f759b1eef65
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Oct 11 21:43:01 2018

webm colour parser: fix some webm symbols

Pull some symbols from libwebm and remove other apparently
unused.

Bug:  894226 
Change-Id: I5a5b3fd199f40cdf363a6ce7d6cee7400e77de53
Reviewed-on: https://chromium-review.googlesource.com/c/1274567
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598958}
[modify] https://crrev.com/281cab6e153d01a5133cb73c3d334f759b1eef65/media/formats/BUILD.gn
[add] https://crrev.com/281cab6e153d01a5133cb73c3d334f759b1eef65/media/formats/webm/DEPS
[modify] https://crrev.com/281cab6e153d01a5133cb73c3d334f759b1eef65/media/formats/webm/webm_colour_parser.cc

Comment 2 by mcasas@chromium.org, Oct 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment