Guest mode is disabled when sign in is not forced. |
|||||||
Issue descriptionChrome Version: 70+ OS: Win and Mac What steps will reproduce the problem? (1) Setup ForceBrowserSignin policy with 1 (2) Setup BrowserSignin policy wit 0 or 1. (3) Make sure guest session policy is not set. (4) Open Chrome What is the expected result? Sign in is not forced, user could use guest mode. What happens instead? Guest mode is disabled.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df7614ec9e3c573b71afb3aea7b9d3db54d518bb commit df7614ec9e3c573b71afb3aea7b9d3db54d518bb Author: Owen Min <zmin@chromium.org> Date: Fri Oct 12 16:38:02 2018 Do not disable guest mode when BrowserSignin override ForceBrowesrSignin without a forced value Bug: 894212 Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1274196 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599247} [modify] https://crrev.com/df7614ec9e3c573b71afb3aea7b9d3db54d518bb/chrome/browser/profiles/guest_mode_policy_handler.cc [modify] https://crrev.com/df7614ec9e3c573b71afb3aea7b9d3db54d518bb/chrome/browser/profiles/guest_mode_policy_handler_unittest.cc
,
Oct 15
The patch has been verified in Canary(72.0.3581.0) and it needs to be merged back into 71. The code has also been covered by unit test.
,
Oct 15
,
Oct 16
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba7803ff0e38b1a7859a17708ced2b5117728ba commit fba7803ff0e38b1a7859a17708ced2b5117728ba Author: Owen Min <zmin@chromium.org> Date: Tue Oct 16 21:00:53 2018 Merge Do not disable guest mode when BrowserSignin override ForceBrowesrSignin without a forced value. Merge the patch into M71. Bug: 894212 Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1274196 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599247}(cherry picked from commit df7614ec9e3c573b71afb3aea7b9d3db54d518bb) Reviewed-on: https://chromium-review.googlesource.com/c/1284729 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#66} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/fba7803ff0e38b1a7859a17708ced2b5117728ba/chrome/browser/profiles/guest_mode_policy_handler.cc [modify] https://crrev.com/fba7803ff0e38b1a7859a17708ced2b5117728ba/chrome/browser/profiles/guest_mode_policy_handler_unittest.cc
,
Oct 16
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba7803ff0e38b1a7859a17708ced2b5117728ba Commit: fba7803ff0e38b1a7859a17708ced2b5117728ba Author: zmin@chromium.org Commiter: zmin@chromium.org Date: 2018-10-16 21:00:53 +0000 UTC Merge Do not disable guest mode when BrowserSignin override ForceBrowesrSignin without a forced value. Merge the patch into M71. Bug: 894212 Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3 Reviewed-on: https://chromium-review.googlesource.com/c/1274196 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599247}(cherry picked from commit df7614ec9e3c573b71afb3aea7b9d3db54d518bb) Reviewed-on: https://chromium-review.googlesource.com/c/1284729 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#66} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by zmin@chromium.org
, Oct 10