It seems that the *SharedData APIs are simply some duplications based on DataShelf* APIs, and can be deprecated according to the docstring. Can try to remove them for better readability.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ee5943dc65f510822eff908cb9462064d03b3f8a commit ee5943dc65f510822eff908cb9462064d03b3f8a Author: Fei Shao <fshao@google.com> Date: Tue Nov 13 16:22:59 2018 factory: Remove duplicated APIs in state.py In state.py, *SharedData APIs are just some duplications from DataShelf* APIs, so they are removed now. BUG= chromium:894181 TEST=make test Change-Id: Icc2e682d7f6f683d2d20eca95ab5d26af0eea785 Reviewed-on: https://chromium-review.googlesource.com/1274505 Commit-Ready: Fei Shao <fshao@chromium.org> Tested-by: Fei Shao <fshao@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/goofy_rpc.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/pytests/shutdown.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/goofy_unittest.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/pytests/start.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/invocation.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/test_ui.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/device/links/ssh.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/device_data.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/pytests/bluetooth.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/state.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/plugins/system_log_manager.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/goofy.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/pytests/touchscreen_calibration/touchscreen_calibration.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/state_unittest.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/pytests/scan.py [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/goofy/js/goofy.js [modify] https://crrev.com/ee5943dc65f510822eff908cb9462064d03b3f8a/py/test/utils/goofy_plugin_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a3f3383881a24ad5531a59a1558f30f37c7745db commit a3f3383881a24ad5531a59a1558f30f37c7745db Author: Yong Hong <yhong@chromium.org> Date: Tue Nov 20 13:52:36 2018 state: Fix RPC function call error. According to JSON-RPC spec, the caller cannot use both positional and keyword arguments while calling a function via JSON-RPC proxy. BUG= chromium:894181 TEST=make test Change-Id: Ic839f4b463f6b1d8c0b1f1456c069e5097e7b06d Reviewed-on: https://chromium-review.googlesource.com/1337237 Commit-Ready: Fei Shao <fshao@chromium.org> Tested-by: Yong Hong <yhong@google.com> Reviewed-by: Fei Shao <fshao@chromium.org> [modify] https://crrev.com/a3f3383881a24ad5531a59a1558f30f37c7745db/py/test/state.py [modify] https://crrev.com/a3f3383881a24ad5531a59a1558f30f37c7745db/py/test/pytests/shutdown.py [modify] https://crrev.com/a3f3383881a24ad5531a59a1558f30f37c7745db/py/test/device_data.py
Comment 1 Deleted