DeviceService using SystemSharedURLLoaderFactory on ServiceManagerContext creation |
|||
Issue descriptionWhen Creating the ServiceManagerContext, DeviceService will try go get the SystemSharedURLLoaderFactor: https://cs.chromium.org/chromium/src/content/browser/service_manager/service_manager_context.cc?q=servicemanagercontext&dr=CSs&l=533 Since the network service and g_browser_process is not created yet, this call will raise an NPE if we start service manager alone.
,
Oct 11
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da0d55bd09b994d2eb167b7f4daea8da5f308aa1 commit da0d55bd09b994d2eb167b7f4daea8da5f308aa1 Author: Min Qin <qinmin@chromium.org> Date: Fri Oct 12 18:30:05 2018 Pass system SharedURLLoaderFactory in a wrapper to DeviceService DeviceService retrieves system SharedURLLoaderFactory on creation. If ServiceManagerContext is created before browser process, the SharedURLLoaderFactory cannot be accessed. This CL provides a wrapper for system SharedURLLoaderFactory, and pass it to DeviceService, so that it can be used later when network service is created. BUG= 894167 Change-Id: Ibd7ed15399d247f7dc5b9eee99edf331b85ac04b Reviewed-on: https://chromium-review.googlesource.com/c/1274485 Reviewed-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599301} [modify] https://crrev.com/da0d55bd09b994d2eb167b7f4daea8da5f308aa1/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/da0d55bd09b994d2eb167b7f4daea8da5f308aa1/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/da0d55bd09b994d2eb167b7f4daea8da5f308aa1/extensions/shell/BUILD.gn [delete] https://crrev.com/df755070086c231bea487bb50630debf9ac5362b/extensions/shell/browser/geolocation/geolocation_apitest.cc [delete] https://crrev.com/df755070086c231bea487bb50630debf9ac5362b/extensions/test/data/geolocation/always_position_unavailable/main.js [delete] https://crrev.com/df755070086c231bea487bb50630debf9ac5362b/extensions/test/data/geolocation/always_position_unavailable/manifest.json
,
Oct 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by qin...@chromium.org
, Oct 10