New issue
Advanced search Search tips

Issue 894159 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Participants' hotlists:
Downloads-Home-Rework


Sign in to add a comment

[Downloads Home] Paused download shows up as failed after restart

Project Member Reported by shaktisahu@chromium.org, Oct 10

Issue description

Steps:
1 - Start a download (generic item)
2 - Pause the download
3 - Restart chrome and open download home.

Observe : The description says 70 MB / 200 MB - failed
Expected : It should be paused instead
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f79b8adc667c1af926293cab8d4550b9a810292

commit 7f79b8adc667c1af926293cab8d4550b9a810292
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Oct 18 01:22:30 2018

Download home : Fixed paused/pending state

This CL fixes
1 - Paused downloads showing up as failed after browser restart
2 - Pending for network downloads showing up as failed

Bug:  894159 
Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49
Reviewed-on: https://chromium-review.googlesource.com/c/1284889
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600630}
[modify] https://crrev.com/7f79b8adc667c1af926293cab8d4550b9a810292/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java

Labels: Merge-Request-71
Owner: shaktisahu@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f691b601994b849b98a976a2a166490d38d7902

commit 7f691b601994b849b98a976a2a166490d38d7902
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Oct 19 20:30:14 2018

Download home : Fixed paused/pending state

This CL fixes
1 - Paused downloads showing up as failed after browser restart
2 - Pending for network downloads showing up as failed

Bug:  894159 
Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49
Reviewed-on: https://chromium-review.googlesource.com/c/1284889
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600630}(cherry picked from commit 7f79b8adc667c1af926293cab8d4550b9a810292)
Reviewed-on: https://chromium-review.googlesource.com/c/1292520
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#169}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/7f691b601994b849b98a976a2a166490d38d7902/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7f691b601994b849b98a976a2a166490d38d7902

Commit: 7f691b601994b849b98a976a2a166490d38d7902
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-10-19 20:30:14 +0000 UTC

Download home : Fixed paused/pending state

This CL fixes
1 - Paused downloads showing up as failed after browser restart
2 - Pending for network downloads showing up as failed

Bug:  894159 
Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49
Reviewed-on: https://chromium-review.googlesource.com/c/1284889
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600630}(cherry picked from commit 7f79b8adc667c1af926293cab8d4550b9a810292)
Reviewed-on: https://chromium-review.googlesource.com/c/1292520
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#169}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Verified (was: Fixed)
Verified in M71-71.0.3578.20
pause.png
172 KB View Download

Sign in to add a comment