New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894149 link

Starred by 1 user
Status: Assigned
Owner:
yiyix@chromium.org
Cc:
█ fsam...@chromium.org
sadrul@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Creating metrics for skipped frames

Project Member Reported by yiyix@chromium.org, Oct 10 
Creating metrics for skipped frames
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807099e22e90b7d48628c51719ebc718077fc3d2

commit 807099e22e90b7d48628c51719ebc718077fc3d2
Author: yiyix <yiyix@chromium.org>
Date: Fri Nov 09 05:24:28 2018

FrameMetrics: Add Idle stage to SkippedFrameTracker

When SetNeedsBeginFrame is set to false or it is not scrolling, update
the SkippedFrameTracker to idle state. So that the skipped frame tracker
only measures the skip frame count during scrolling.

Design doc:
https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg/

Bug: 894149
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifcc23fba56abb6213dcf593f8d272aeab322372a
Reviewed-on: https://chromium-review.googlesource.com/c/1284432
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606746}
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/scheduler/scheduler.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/scheduler/scheduler.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/scheduler/scheduler_unittest.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/layer_tree_frame_sink_client.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/proxy_impl.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/proxy_impl.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/cc/trees/single_thread_proxy.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/ui/latency/skipped_frame_tracker.cc
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/ui/latency/skipped_frame_tracker.h
[modify] https://crrev.com/807099e22e90b7d48628c51719ebc718077fc3d2/ui/latency/skipped_frame_tracker_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e71a98c5f020c4af56d2a092512bb87742c1db

commit 08e71a98c5f020c4af56d2a092512bb87742c1db
Author: yiyix <yiyix@chromium.org>
Date: Wed Nov 14 02:15:07 2018

FrameMetrics: Track the skipped frame rate during scrolling event only

Skipped Frame tracker used to record every frame produced at all times.
With that approach, it's hard to study the correlation between the user
actions and the skipped frame rate. In this patch, we only track the
skipped frame rate during scrolling events. More user actions will be
added in the future cls.

Design doc on skipped frame tracker:
https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg

Videos on how it used to work:
https://drive.google.com/open?id=1S5fnq8VrqvUIYFZjvIi4GNA3ekIdggG0

Bug: 894149

Change-Id: I02441cb5c9f551cc80b51ea1dcbafa3c492cb5ce
Reviewed-on: https://chromium-review.googlesource.com/c/1334103
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607861}
[modify] https://crrev.com/08e71a98c5f020c4af56d2a092512bb87742c1db/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/08e71a98c5f020c4af56d2a092512bb87742c1db/ui/latency/skipped_frame_tracker_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f559c7c94d4d41d055bb02700e6178b17a3279

commit b7f559c7c94d4d41d055bb02700e6178b17a3279
Author: yiyix <yiyix@chromium.org>
Date: Wed Nov 14 17:01:22 2018

FrameMetrics: Add more comments to unittests

Bug: 894149

TBR=sadrul@chromium.org

Change-Id: Ibeece84bc1490050a9c61c8deb976c370506e45e
Reviewed-on: https://chromium-review.googlesource.com/c/1335279
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608016}
[modify] https://crrev.com/b7f559c7c94d4d41d055bb02700e6178b17a3279/ui/latency/skipped_frame_tracker_unittest.cc
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13a18bba140000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Dec 7 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16f89df2140000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Dec 11 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/15edc7d2140000

All of the runs failed. The most common error (10/20 runs) was:
SwarmingTestError: The test failed. No Python exception was found in the log.

Comment 16 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment