Resuming a paused download disappears from download home when there is not enough disk space |
|
Issue descriptionSteps 1 - Start a 500MB download. 2 - Pause the download. 3 - Fill the diskspace by other downloads. 4 - Resume download (from notification or download home) Observe : The download resumes and immediately disappears. Expected : We should at least provide show failure message/warning to the user about what happened. This happens due to calling Cancel() after DownloadTargetDeterminer step.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df2070a232c93de1a6e47018079934bbe0896d8a commit df2070a232c93de1a6e47018079934bbe0896d8a Author: Min Qin <qinmin@chromium.org> Date: Thu Oct 11 18:19:10 2018 Fix an issue that download cannot resume after browser crash Android defaults target determination to prompt. However, in the case of resumption, we should not prompt user. Instead, we should simply uniquify the file name The issue is fixed in https://codereview.chromium.org/2618743006/ But reintroduced by https://chromium-review.googlesource.com/c/chromium/src/+/465566 BUG=894134 Change-Id: If05394eb9970f79c91770a29fc7761d41228c92e Reviewed-on: https://chromium-review.googlesource.com/c/1275129 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#598849} [modify] https://crrev.com/df2070a232c93de1a6e47018079934bbe0896d8a/chrome/browser/download/chrome_download_manager_delegate.cc |
|
►
Sign in to add a comment |
|
Comment 1 by dtrainor@chromium.org
, Oct 10Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)