Issue metadata
Sign in to add a comment
|
7.4%-24.9% regression in rendering.desktop/frame_times at 597989:598085 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 10
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11e328eae40000
,
Oct 10
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11e328eae40000 Remove FlushForDriverCrashWorkaround by ccameron@chromium.org https://chromium.googlesource.com/chromium/src/+/b0587ce32c778a4fcc2cb5802d3eabc44e315b24 TabCapturePerformance_comp_gpu: 21.18 → 25.74 (+4.562) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Oct 10
+vmiura & +kbr as FYI -- apparently *removing* the excessive glFlush causes performance regressions. (WontFix, of course).
,
Oct 10
Interesting. Before James' transfer buffer resizing changes, there were probably frequent enough flushes during Chrome's regular rendering operations to keep the overlap high between the renderer and GPU processes. frame_times/motion_mark_canvas_fill_shapes in rendering.desktop and TabCapturePerformance_comp_gpu/Capture in performance_browser_tests were the two benchmarks affected here.
,
Oct 10
fserb@ fyi for the canvas regressions. The tab capture metric looks like it just reverted to it's long term value before this workaround landed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 10