New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 894117 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 863817



Sign in to add a comment

7.4%-24.9% regression in rendering.desktop/frame_times at 597989:598085

Project Member Reported by m...@chromium.org, Oct 10

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=894117

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=50fdb80750934403dc41c6c85f13a18225bf3075ee5dde74126a4afd57247b19


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: ccameron@chromium.org
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11e328eae40000

Remove FlushForDriverCrashWorkaround by ccameron@chromium.org
https://chromium.googlesource.com/chromium/src/+/b0587ce32c778a4fcc2cb5802d3eabc44e315b24
TabCapturePerformance_comp_gpu: 21.18 → 25.74 (+4.562)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: kbr@chromium.org vmiura@google.com
Status: WontFix (was: Assigned)
+vmiura & +kbr as FYI -- apparently *removing* the excessive glFlush causes performance regressions.

(WontFix, of course).
Blocking: 863817
Cc: jdarpinian@chromium.org
Interesting. Before James' transfer buffer resizing changes, there were probably frequent enough flushes during Chrome's regular rendering operations to keep the overlap high between the renderer and GPU processes. frame_times/motion_mark_canvas_fill_shapes in rendering.desktop and TabCapturePerformance_comp_gpu/Capture in performance_browser_tests were the two benchmarks affected here.

Cc: fs...@chromium.org
fserb@ fyi for the canvas regressions.

The tab capture metric looks like it just reverted to it's long term value before this workaround landed.

Sign in to add a comment