New issue
Advanced search Search tips

Issue 894112 link

Starred by 1 user
Status: Fixed
Owner:
mheikal@chromium.org
Closed: Oct 10
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 891475



Sign in to add a comment

Remove leak canary from our build system

Project Member Reported by mheikal@chromium.org, Oct 10 
Leak canary was added ( issue 505909 ) to help detect memory leaks from activity pointers however it was never widely used and could not be shipped to users.

Currently it breaks dexing in release mode ( issue 891475 ) and thus we should remove it from the build system.

Comment 1 by mheikal@chromium.org, Oct 10

Blocking: 891475
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b02e7f417fff7847666f62dbea739999b105537e

commit b02e7f417fff7847666f62dbea739999b105537e
Author: Mohamed Heikal <mheikal@chromium.org>
Date: Wed Oct 10 20:21:10 2018

[Android] Remove LeakCanary from chrome

Leak Canary is not used and has not been updated in a while. It is
currently breaking dexing in release (see  crbug.com/891475 ). Removing
from the repo.

Bug:  894112 
Change-Id: I36ef22205d1dde963e136d9721752cb4e4bfc017
Reviewed-on: https://chromium-review.googlesource.com/c/1274050
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598477}
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/DEPS
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/build/android/bytecode/java/org/chromium/bytecode/CustomResourcesClassAdapter.java
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/build/android/bytecode/java/org/chromium/bytecode/TypeUtils.java
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/chrome/android/BUILD.gn
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/third_party/.gitignore
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/haha/BUILD.gn
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/haha/LICENSE
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/haha/OWNERS
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/haha/README.chromium
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/haha/haha-2.0.2.jar
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/BUILD.gn
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/LICENSE
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/OWNERS
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/README.chromium
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/config.gni
[delete] https://crrev.com/aac40ceff0ef299bc26b69a23b5cdc6e500e31d5/third_party/leakcanary/leakcanary-android-build-config/com/squareup/leakcanary/BuildConfig.java
[modify] https://crrev.com/b02e7f417fff7847666f62dbea739999b105537e/tools/android/eclipse/.classpath

Comment 3 by mheikal@chromium.org, Oct 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment