Disable welcome app on tablets |
||||||||||||
Issue descriptionWelcome app is not tablet optimized. We should disable it from appearing on tablet devices (currently dru, soraka, nocturne but would be nice to have a scaleable solution). Need for M-71.
,
Oct 17
Need for M-71
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b0ab6e535bdf0c2e0a7198ef717a0020757bd33 commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Oct 17 18:01:58 2018 Chrome OS: Disable Discover app by default This disables Discover App. Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#600473} [modify] https://crrev.com/1b0ab6e535bdf0c2e0a7198ef717a0020757bd33/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/1b0ab6e535bdf0c2e0a7198ef717a0020757bd33/chromeos/chromeos_switches.cc [modify] https://crrev.com/1b0ab6e535bdf0c2e0a7198ef717a0020757bd33/chromeos/chromeos_switches.h
,
Oct 17
Clarifying: - We should disable the new "Discover" app on all devices. - We should disable the old "Howdy, user" app on tablet devices only.
,
Oct 17
We'll just check "is_tablet_mode" flag, which will disable the app on a convertible which happens to be in tablet mode during sign-in. This should be WAI?
,
Oct 17
Yep that's perfect!
,
Oct 17
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41183d85d5310492ca1dc4e672d2b2f5a6215e66 commit 41183d85d5310492ca1dc4e672d2b2f5a6215e66 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Oct 18 00:15:07 2018 Chrome OS: Disable Welcome app by default This disables Welcome App on selected devices. Bug: 894095 Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170 Reviewed-on: https://chromium-review.googlesource.com/c/1287184 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#600616} [modify] https://crrev.com/41183d85d5310492ca1dc4e672d2b2f5a6215e66/chrome/browser/chromeos/first_run/first_run.cc
,
Oct 18
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b57671c127fe29fd94c2de3187f7804dbe913b commit 72b57671c127fe29fd94c2de3187f7804dbe913b Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Oct 19 01:20:57 2018 Chrome OS: Disable Discover app by default This disables Discover App. TBR=alemate@chromium.org (cherry picked from commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33) Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600473} Reviewed-on: https://chromium-review.googlesource.com/c/1290203 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#144} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/72b57671c127fe29fd94c2de3187f7804dbe913b/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/72b57671c127fe29fd94c2de3187f7804dbe913b/chromeos/chromeos_switches.cc [modify] https://crrev.com/72b57671c127fe29fd94c2de3187f7804dbe913b/chromeos/chromeos_switches.h
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8288b70ad83a50164057a98fb28b0120ee8ac47 commit c8288b70ad83a50164057a98fb28b0120ee8ac47 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Oct 19 01:26:47 2018 Chrome OS: Disable Welcome app by default This disables Welcome App on selected devices. TBR=alemate@chromium.org (cherry picked from commit 41183d85d5310492ca1dc4e672d2b2f5a6215e66) Bug: 894095 Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170 Reviewed-on: https://chromium-review.googlesource.com/c/1287184 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600616} Reviewed-on: https://chromium-review.googlesource.com/c/1290204 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#145} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/c8288b70ad83a50164057a98fb28b0120ee8ac47/chrome/browser/chromeos/first_run/first_run.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b57671c127fe29fd94c2de3187f7804dbe913b Commit: 72b57671c127fe29fd94c2de3187f7804dbe913b Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-19 01:20:57 +0000 UTC Chrome OS: Disable Discover app by default This disables Discover App. TBR=alemate@chromium.org (cherry picked from commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33) Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600473} Reviewed-on: https://chromium-review.googlesource.com/c/1290203 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#144} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8288b70ad83a50164057a98fb28b0120ee8ac47 Commit: c8288b70ad83a50164057a98fb28b0120ee8ac47 Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-19 01:26:47 +0000 UTC Chrome OS: Disable Welcome app by default This disables Welcome App on selected devices. TBR=alemate@chromium.org (cherry picked from commit 41183d85d5310492ca1dc4e672d2b2f5a6215e66) Bug: 894095 Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170 Reviewed-on: https://chromium-review.googlesource.com/c/1287184 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600616} Reviewed-on: https://chromium-review.googlesource.com/c/1290204 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#145} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
,
Nov 8
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e56152aa68910db4d475eab5e31a621431d1cf commit f1e56152aa68910db4d475eab5e31a621431d1cf Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Nov 08 21:57:43 2018 Chrome OS: Disable Discover app by default This disables Discover App. TBR=alemate@chromium.org (cherry picked from commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33) (cherry picked from commit 72b57671c127fe29fd94c2de3187f7804dbe913b) Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#600473} Reviewed-on: https://chromium-review.googlesource.com/c/1290203 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3578@{#144} Cr-Original-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Reviewed-on: https://chromium-review.googlesource.com/c/1327465 Cr-Commit-Position: refs/branch-heads/3538@{#1078} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/f1e56152aa68910db4d475eab5e31a621431d1cf/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc [modify] https://crrev.com/f1e56152aa68910db4d475eab5e31a621431d1cf/chromeos/chromeos_switches.cc [modify] https://crrev.com/f1e56152aa68910db4d475eab5e31a621431d1cf/chromeos/chromeos_switches.h
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e56152aa68910db4d475eab5e31a621431d1cf Commit: f1e56152aa68910db4d475eab5e31a621431d1cf Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-11-08 21:57:43 +0000 UTC Chrome OS: Disable Discover app by default This disables Discover App. TBR=alemate@chromium.org (cherry picked from commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33) (cherry picked from commit 72b57671c127fe29fd94c2de3187f7804dbe913b) Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#600473} Reviewed-on: https://chromium-review.googlesource.com/c/1290203 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3578@{#144} Cr-Original-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} Reviewed-on: https://chromium-review.googlesource.com/c/1327465 Cr-Commit-Position: refs/branch-heads/3538@{#1078} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rkc@google.com
, Oct 17