New issue
Advanced search Search tips

Issue 894089 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 875032
Owner: ----
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

jingle/notifier/base/notifier_options.h depends on URLRequestContextGetter.

Project Member Reported by mmenke@chromium.org, Oct 10

Issue description

URLRequestContextGetter is deprecated, and should no longer be used. New code should be written to work with the NetworkService instead, which may be out of process.  It looks like this code just uses the URLRequestContextGetter to get a thread (?) for reasons that are unclear to me.  I'm unsure whether the UI thread should be passed in instead when the network service is disabled (When it's enabled, too?), or if there's something else that needs to be done.
 
Mergedinto: 875032
Status: Duplicate (was: Untriaged)
This is what that CL is about...
Thanks, Maks.  I didn't see any connections to Jingle's use of HttpNetworkSession, so wasn't sure if this was on your radar.

Sign in to add a comment