Issue metadata
Sign in to add a comment
|
Tab Grid's page title is blank |
||||||||||||||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 71.0.3568.0 dev iOS Version: 12 Device: iPhone XS Steps to reproduce: Steps to reproduce: 0.) Make sure that Amazon app is installed 1.) Load https://bgr.com/2018/10/09/philips-hue-color-bulbs-sale-amazon-halloween/ 2.) Tap on "Phillips Hue LightStrip Plus" link, which launches Amazon app 3.) Come back to Chrome app 4.) Open tab grid Observed behavior: Tab title is blank Expected behavior: Tab title should be untitled Additional comments: This is just one case when title is not correct. The root cause is that Tab Grid does not use tab_util::GetTabTitle API. Tab.title was used by old tab switcher. Tab.title was later replaced by tab_util::GetTabTitle.
,
Oct 10
Ed, ptal and also mark RBS as appropriate.
,
Oct 10
I think we should fix this, but not so sure about why this specific issue should "block" a release.
,
Oct 11
We often treat regressions as RBS, but this one is already shipped regression
,
Nov 7
,
Nov 7
Ed, can we prioritize this regression bug? The fix should not be complex.
,
Nov 7
Will fix.
,
Nov 7
Thanks Ed! Please note that trunk and branch have diverged, and the fix will not be cherry pickable to M71.
,
Nov 27
This was regressed in M69, but was reported for M71 so it isn't a release blocker for M71. I wanted to fix this but did not get around to it. I will get it fixed this week for M72.
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5ed691a1de5ac2fda5b96d6f2c9901d68e7561f commit f5ed691a1de5ac2fda5b96d6f2c9901d68e7561f Author: edchin <edchin@chromium.org> Date: Fri Dec 28 15:25:44 2018 [ios] Use tab title util in tab grid This CL uses the tab title util in tab grid, which handles more edge cases around the WebState's title. Bug: 894081 Change-Id: I66d90a877f1bfb716e0c1327ea0bf8abf1dd49b8 Reviewed-on: https://chromium-review.googlesource.com/c/1391709 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619156} [modify] https://crrev.com/f5ed691a1de5ac2fda5b96d6f2c9901d68e7561f/ios/chrome/browser/tabs/tab_title_util.mm [modify] https://crrev.com/f5ed691a1de5ac2fda5b96d6f2c9901d68e7561f/ios/chrome/browser/ui/tab_grid/tab_grid_mediator.mm
,
Dec 29
,
Jan 8
Verified on chrome canary version 73.0.3665.0 on iPhone XS with iOS 12.1.2, following the steps mentioned in comment #0. Tab title is "Untitled". Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by eugene...@chromium.org
, Oct 10