New issue
Advanced search Search tips

Issue 894079 link

Starred by 2 users
Status: Duplicate
Merged: issue 838964
Owner: ----
Closed: Oct 11
Cc:
jam@chromium.org
msramek@chromium.org
dxie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

ConditionalCacheCountingHelper doesn't work when the network service is enabled

Project Member Reported by mmenke@chromium.org, Oct 10 
ConditionalCacheCountingHelper still uses URLRequestContext, rather than NetworkContext, so doesn't work when using the network service.

Comment 1 by dxie@google.com, Oct 11 

what is the effect of this? Is this an estimation of data counts to be removed in the data browsing remover?

Comment 2 by dxie@google.com, Oct 11

Cc: jam@chromium.org dxie@chromium.org

Comment 3 by msramek@chromium.org, Oct 11 

Re #1: Correct. This is wired to the data counts in the Clear Browsing Data dialog.

Comment 4 by jam@chromium.org, Oct 11 

How important is this, i.e. is it ok to go to stable without it?

Comment 5 by jam@chromium.org, Oct 11

Mergedinto: 838964
Status: Duplicate (was: Untriaged)
Actually, looks like this was converted already in  bug 838964 . URLRequestContext is only used if the network service is disabled.

Marking as a dup, but please re-open if I'm mistaken.

Comment 6 by morlovich@chromium.org, Oct 11 

You're correct, see this conditional:
https://chromium-review.googlesource.com/c/chromium/src/+/1069193/29/components/browsing_data/content/conditional_cache_counting_helper.cc#69

BTW, the reason all the old code is still in place is because it needs to deal with the media cache when network service is off...
►

Sign in to add a comment