Refactor CocoaProfileTest to use/be TestWithBrowserView |
|
Issue descriptionAs part of the cleanup from switching to MacViews, in 8c4cad73339261d5b56307f5d25c94a7f7206425 I made the CocoaProfileTest bootstrap the views environment (https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/test/cocoa_profile_test.h?l=34&rcl=c6688ec4c44a58194099f4c950e65f8545893e41), so that it can open browser windows and use the profile object (which is what subclasses of CPT do). This is almost entirely redundant with the TestWithBrowserView class (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/test_with_browser_view.h?l=18&rcl=b8f357b9681021da68662d52c544e7c7bc919daa). These two should somehow be merged/combined. But the Mac version may still need to do some of the work that CocoaTest (CocoaProfileTest's superclass) does. That includes setting animation durations, setting up the framework bundle override, draining the autorelease pool, checking for left-around NSWindows, etc. (https://cs.chromium.org/chromium/src/ui/base/test/cocoa_helper.mm?l=146&rcl=b8f357b9681021da68662d52c544e7c7bc919daa) |
|
►
Sign in to add a comment |
|
Comment 1 by ellyjo...@chromium.org
, Oct 19