New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894064 link

Starred by 2 users
Status: Assigned
Owner:
█ jennschen@chromium.org
Last visit > 30 days ago
Cc:
pkotw...@chromium.org
juman...@yandex-team.ru
dcheng@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use file type icon as favicon for file:// URLs

Project Member Reported by pkotw...@chromium.org, Oct 10 
Repro steps:
1) Launch Chrome on Desktop
2) Navigate to file:// URL
3) Look at tab favicon

Currently, a blank page is used for all file URLs. It might be helpful to use the file type icon as the favicon instead

Comment 1 by pkotw...@chromium.org, Oct 10

Cc: pkotw...@chromium.org juman...@yandex-team.ru dcheng@chromium.org
Owner: jennschen@chromium.org
Tentatively assigning this bug to jennschen@ for UX input as to whether this change is a good change.

A 3rd party developer is suggesting this change and has posted a CL - https://chromium-review.googlesource.com/c/chromium/src/+/1158689 - (which I LGTMed) for this change. dcheng@ suggested that a UX review might be necessary

I have attached screen shots of the sample before (tab_strip_blank.png) and after (tab_strip_with_file_type_favicons.png) state. For the sake of clarity, this change only affects the favicon for file:// URLs. It does not affect the favicon for non file:// URLs which currently use the default favicon
tab_strip_blank_favicons.png
13.2 KB View Download
tab_strip_with_file_type_favicons.png
13.9 KB View Download

Comment 2 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment