New issue
Advanced search Search tips

Issue 894043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean-up and add canvas metrics

Project Member Reported by aaronhk@chromium.org, Oct 10

Issue description

Current canvas metrics need to be re-evaluated. Offscreen canvas needs metrics to be added. 
 
Labels: -Pri-1 Pri-2
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b65449a26d80058c6a2933321bcd8e0463794f07

commit b65449a26d80058c6a2933321bcd8e0463794f07
Author: Aaron Krajeski <aaronhk@google.com>
Date: Mon Oct 15 17:27:22 2018

Add metrics for offscreen canvas

Bug:  894043 
Change-Id: Idcfd3f4d430c7bce4c13448c80996128ca831f72
Reviewed-on: https://chromium-review.googlesource.com/c/1265815
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599659}
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.cc
[modify] https://crrev.com/b65449a26d80058c6a2933321bcd8e0463794f07/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb4e41ca20a00dc6af65134d1e998a3776997c6

commit 0bb4e41ca20a00dc6af65134d1e998a3776997c6
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Tue Oct 23 15:47:09 2018

Fix canvas.contextType histogram enums and replace old macro

Current set up has buckets labeled as 6, 7 & 8. This adds the enum
strings as well as replaces old uses of the old UMA metrics macro.

Bug:  894043 
Change-Id: Ic6b5d97ef673c78f41d9d7ae7764b93ba3f7b602
Reviewed-on: https://chromium-review.googlesource.com/c/1292716
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601968}
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/0bb4e41ca20a00dc6af65134d1e998a3776997c6/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87eb90f8636bacdcdead0404d12c599546d1a3de

commit 87eb90f8636bacdcdead0404d12c599546d1a3de
Author: Aaron Krajeski <aaronhk@google.com>
Date: Tue Oct 23 20:20:18 2018

Use setImmediate to avoid disable-vsync flag for perf tests

Bug:  894043 
Change-Id: I903e42cd2e3673d945864fff6e8386890d4eb410
Reviewed-on: https://chromium-review.googlesource.com/c/1293760
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602072}
[modify] https://crrev.com/87eb90f8636bacdcdead0404d12c599546d1a3de/third_party/blink/manual_tests/canvas/utils.js

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e4c64067a1bc55a181794ad392d66e7b4db6ff

commit 93e4c64067a1bc55a181794ad392d66e7b4db6ff
Author: Aaron Krajeski <aaronhk@google.com>
Date: Tue Oct 23 21:34:56 2018

Metrics for canvas resource provider

Bug:  894043 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id777b3e30ce6f9d84b2935630559c62a251d07af
Reviewed-on: https://chromium-review.googlesource.com/c/1289749
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602108}
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[delete] https://crrev.com/25fb524f7642d55c4da0068f9c7ee711221542f9/third_party/blink/renderer/platform/graphics/canvas_metrics.cc
[delete] https://crrev.com/25fb524f7642d55c4da0068f9c7ee711221542f9/third_party/blink/renderer/platform/graphics/canvas_metrics.h
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/93e4c64067a1bc55a181794ad392d66e7b4db6ff/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e733da54f24668cf10b7acd0b8dcaa06250f17d8

commit e733da54f24668cf10b7acd0b8dcaa06250f17d8
Author: Aaron Krajeski <aaronhk@google.com>
Date: Thu Oct 25 17:54:33 2018

Add size/memory and number of canvas metrics

Bug:  894043 
Change-Id: I64e84f72ac1ad419ef30ec410c316485c501f1ae
Reviewed-on: https://chromium-review.googlesource.com/c/1287324
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602783}
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/e733da54f24668cf10b7acd0b8dcaa06250f17d8/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d586ff351d5819052f4408ff1365546b77ea7f

commit 72d586ff351d5819052f4408ff1365546b77ea7f
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Fri Oct 26 17:26:32 2018

Clean-up Canvas metrics - Get/PutImageData

New Histogram now records the time spent on GetImageData and
PutImageData dividing it by the square root of the total number
of pixels of the image.

Bug:  894043 
Change-Id: Ie45c78edf92f4db7a9a4a2c9f44eaef7ee12f72d
Reviewed-on: https://chromium-review.googlesource.com/c/1284433
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603131}
[modify] https://crrev.com/72d586ff351d5819052f4408ff1365546b77ea7f/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/72d586ff351d5819052f4408ff1365546b77ea7f/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
[modify] https://crrev.com/72d586ff351d5819052f4408ff1365546b77ea7f/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/914c23fa57bc891d85780d34534c80d8a7c4f395

commit 914c23fa57bc891d85780d34534c80d8a7c4f395
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Fri Oct 26 22:55:22 2018

Clean-up Canvas metrics - DrawImage

Use of new macro and added base=true to avoid extra suffix histograms

Bug:  894043 
Change-Id: I2f87f092a01897c43fcd8b61639967fed2330f50
Reviewed-on: https://chromium-review.googlesource.com/c/1283833
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603237}
[modify] https://crrev.com/914c23fa57bc891d85780d34534c80d8a7c4f395/base/metrics/histogram_functions.cc
[modify] https://crrev.com/914c23fa57bc891d85780d34534c80d8a7c4f395/base/metrics/histogram_functions.h
[modify] https://crrev.com/914c23fa57bc891d85780d34534c80d8a7c4f395/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/914c23fa57bc891d85780d34534c80d8a7c4f395/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e1dedacd5a912bcb057eebf66ad00b9221af2c1

commit 8e1dedacd5a912bcb057eebf66ad00b9221af2c1
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Tue Oct 30 02:11:56 2018

Clean-up canvas.toBlob histograms

Replaced ToBlobDuration with ScaledDuration (divided by the sqrt of
total number of pixels). As well as replaced old macros for the rest
of the toBlob histograms.

Bug:  894043 
Change-Id: I233e0d1973eba3e2d3465e25c1cd6acd70706525
Reviewed-on: https://chromium-review.googlesource.com/c/1298078
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Robert Kaplow (OOO until Nov6) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603737}
[modify] https://crrev.com/8e1dedacd5a912bcb057eebf66ad00b9221af2c1/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/8e1dedacd5a912bcb057eebf66ad00b9221af2c1/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h
[modify] https://crrev.com/8e1dedacd5a912bcb057eebf66ad00b9221af2c1/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/624867abc8a56c48efab78b7883f7fa913daea52

commit 624867abc8a56c48efab78b7883f7fa913daea52
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Thu Nov 01 17:50:53 2018

Remove Offscreen Canvas Commit Timer histogram.

Deprecate histogram and remove all references.

Bug:  894043 
Change-Id: I101f75fc0882a7844a58507a194eb1a5efde207e
Reviewed-on: https://chromium-review.googlesource.com/c/1308755
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604632}
[modify] https://crrev.com/624867abc8a56c48efab78b7883f7fa913daea52/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/624867abc8a56c48efab78b7883f7fa913daea52/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/624867abc8a56c48efab78b7883f7fa913daea52/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e67cb86221dd019f41c63fd3347f6c8555f70d

commit f0e67cb86221dd019f41c63fd3347f6c8555f70d
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Thu Nov 01 21:32:20 2018

Fix multiple canvas enum histograms

Added the prefix "Blink." for consistency with the rest of canvas'
histograms. Used the new ENUMERATION macro. Cleaned the enum strings
in enums.xml for the following histograms:

Canvas.CreateImageBitmapSource
Canvas.GPUAccelerated2DCanvasDisableDeferralReason
Canvas.RequestedImageMimeTypes
Canvas.HibernationEvents

Bug:  894043 
Change-Id: Ifa6afc223e123fea3ef4915b26ff9309e69c710f
Reviewed-on: https://chromium-review.googlesource.com/c/1310914
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604711}
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/third_party/blink/renderer/platform/graphics/graphics_types.h
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f0e67cb86221dd019f41c63fd3347f6c8555f70d/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb31703c196b5bf35d66b6db6aaa10c7fdc598e2

commit fb31703c196b5bf35d66b6db6aaa10c7fdc598e2
Author: David Quiroz Marin <davidqu@chromium.org>
Date: Fri Nov 02 00:02:17 2018

Replace toDataURL histogram with ScaledDuration version

Also updated the old macro to use UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES

Bug:  894043 
Change-Id: I334db198f48bfdad135525639f4bdd9b0ecbc8f6
Reviewed-on: https://chromium-review.googlesource.com/c/1289730
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604762}
[modify] https://crrev.com/fb31703c196b5bf35d66b6db6aaa10c7fdc598e2/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/fb31703c196b5bf35d66b6db6aaa10c7fdc598e2/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7f91f880dcce33af43a1920bcfe2b0f1993ec9

commit 9a7f91f880dcce33af43a1920bcfe2b0f1993ec9
Author: Reid Kleckner <rnk@google.com>
Date: Fri Nov 02 23:40:57 2018

Avoid adding global kMaxValue name to blink namespace

The DisableDeferralReason enum is not scoped, so its members should have
relatively unique names. Without this change, the next version of clang
emits -Wshadow warnings about other enumerators that shadow this
enumerator.

The UMA_HISTOGRAM_ENUMERATION macro supports taking a count argument, so
revert to the kDisableDeferralReasonCount name from before
https://crrev.com/604711 and use it to create the histogram.

BUG= 894043 
TBR=asvitkine@chromium.org, davidqu@chromium.org

Change-Id: Ie7a1f1106393b3c1408d7d1f277db16f8cbbb60f
Reviewed-on: https://chromium-review.googlesource.com/c/1316106
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605095}
[modify] https://crrev.com/9a7f91f880dcce33af43a1920bcfe2b0f1993ec9/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/9a7f91f880dcce33af43a1920bcfe2b0f1993ec9/third_party/blink/renderer/platform/graphics/graphics_types.h

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7149ab705c9a7c1c9c57c960c05e2de216680c7d

commit 7149ab705c9a7c1c9c57c960c05e2de216680c7d
Author: Aaron Krajeski <aaronhk@google.com>
Date: Fri Nov 09 15:28:17 2018

Add RAF tests to blink_perf.canvas benchmark.

Current canvas benchmarks only measure CPU time.
Using requestAnimationFrame (raf) in javascript we can
measure CPU + raster + GPU time. This CL adds a mode to
blink_perf.py that runs canvas all canvas test in a way
that takes raster and GPU time into account.

Roughly doubles the duration of `blink_perf.canvas`
benchmark from ~2 minutes to ~4 minutes on a linux desktop.

Bug:  894043 
Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
Reviewed-on: https://chromium-review.googlesource.com/c/1300038
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606849}
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/docs/speed/benchmark/harnesses/blink_perf.md
[add] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/third_party/blink/perf_tests/canvas/OWNERS
[add] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/third_party/blink/perf_tests/canvas/gpu-bound-shader.html
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/third_party/blink/perf_tests/canvas/resources/canvas_runner.js
[add] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/third_party/blink/perf_tests/canvas/sheets-render.html
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/benchmark.csv
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/7149ab705c9a7c1c9c57c960c05e2de216680c7d/tools/perf/core/shard_maps/win_7_perf_map.json

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78e088afc7c0ad06712c83a5e8a316a4462af78

commit b78e088afc7c0ad06712c83a5e8a316a4462af78
Author: Aaron Krajeski <aaronhk@google.com>
Date: Mon Nov 12 17:12:24 2018

Move blink/manual_tests to blink/perf_tests.

Also adapt them to run automatically with telemetry.
Delete the old folder and its contents.

Bug:  894043 
Change-Id: I5aa4f9172de5ecba0cffd7187ba579b069ae216b
Reviewed-on: https://chromium-review.googlesource.com/c/1315530
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607277}
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/README.md
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/RunAllTests.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/ShowResults.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/docs-paper.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/docs-resume.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/docs-table.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/performance.js
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/sheets-render.html
[delete] https://crrev.com/1b876dd0841d6a1a44a5fbdadff2191012a1e0f1/third_party/blink/manual_tests/canvas/utils.js
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/docs-paper.html
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/docs-resume.html
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/docs-table.html
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/CambriaMath.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/Merriweather-Bold.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/Merriweather-BoldItalic.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/Merriweather-Italic.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/Merriweather-Regular.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/OpenSans-Bold.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/OpenSans-BoldItalic.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/OpenSans-Italic.woff2
[add] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/resources/OpenSans-Regular.woff2
[modify] https://crrev.com/b78e088afc7c0ad06712c83a5e8a316a4462af78/third_party/blink/perf_tests/canvas/sheets-render.html

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f0b4150eb3f05dd866085d332b0652913fd2e8

commit 54f0b4150eb3f05dd866085d332b0652913fd2e8
Author: Aaron Krajeski <aaronhk@google.com>
Date: Wed Nov 28 02:16:37 2018

Add RAF tests to blink_perf.canvas benchmark.

https://chromium-review.googlesource.com/c/chromium/src/+/1351501 has
reverted some perf changes due to high-end mac laptops crashing. Re-add
that CL piece by piece. This CL adds no new tests, only the RAF
functionality.

Current canvas benchmarks only measure CPU time.
Using requestAnimationFrame (raf) in javascript we can
measure CPU + raster + GPU time. This CL adds a mode to
blink_perf.py that runs canvas all canvas test in a way
that takes raster and GPU time into account.

Roughly doubles the duration of `blink_perf.canvas`
benchmark from ~2 minutes to ~4 minutes on a linux desktop.

Bug:  894043 
Change-Id: I50eeacbe47f3f3f0b09f1cb44806cabcad97dc2e
Reviewed-on: https://chromium-review.googlesource.com/c/1352475
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611518}
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/docs/speed/benchmark/harnesses/blink_perf.md
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/third_party/blink/perf_tests/canvas/resources/canvas_runner.js
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/tools/perf/benchmark.csv
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
[modify] https://crrev.com/54f0b4150eb3f05dd866085d332b0652913fd2e8/tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py

Sign in to add a comment