Regression : Unnecessarily focus ring appears on 'Reset' button when user click on +/- icon in 'Zoom' bubble.
Reported by
avsha...@etouch.net,
Oct 10
|
||||
Issue descriptionChrome Version : 71.0.3575.0 (Official Build) e76b693f0dd0af3f866de220286b83a2847f0456-refs/branch-heads/3575@{#1} 32/64 bit OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP and hit 'Ctrl + +' keys to zoom in the current page.(Zoom bubble appears) 2. Immediately click on -/+ button in 'zoom' bubble and observe the 'Reset' button. Actual Result : Unnecessarily focus ring appears on 'Reset' after clicking on +/- icon in 'Zoom' bubble. Expected Result : Focus ring should not appear on 'Reset' after clicking on +/- icon in 'Zoom' bubble. This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information: Good Build : 71.0.3545.0 (Revision : 589378) Bad Build : 71.0.3546.0 (Revision : 589731) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/03fd02e99302521272cdac123a2adb08f0acf447..c4cb73ecadad6fcb2536101a227c55e114017e5e Suspecting : https://chromium.googlesource.com/chromium/src/+/c4cb73ecadad6fcb2536101a227c55e114017e5e James@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you..!
,
Oct 11
,
Oct 11
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89e89b315681b00be37cc3ac6afc00dfed660ff7 commit 89e89b315681b00be37cc3ac6afc00dfed660ff7 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Tue Oct 16 20:27:39 2018 Zoom bubble shouldn't automatically focus reset button Partial revert of crrev/c/1189044. Bug: 894006 Change-Id: I2c2fea22a417f6ae1b97289a4f261263333d5864 Reviewed-on: https://chromium-review.googlesource.com/c/1284055 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#600107} [modify] https://crrev.com/89e89b315681b00be37cc3ac6afc00dfed660ff7/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc [modify] https://crrev.com/89e89b315681b00be37cc3ac6afc00dfed660ff7/chrome/browser/ui/views/location_bar/zoom_bubble_view.h [modify] https://crrev.com/89e89b315681b00be37cc3ac6afc00dfed660ff7/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
,
Oct 16
|
||||
►
Sign in to add a comment |
||||
Comment 1 by robliao@chromium.org
, Oct 11