New issue
Advanced search Search tips

Issue 894004 link

Starred by 2 users
Status: Fixed
Owner:
weili@chromium.org
Closed: Oct 19
Cc:
sdy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

"Always Show Bookmarks Bar" is not enabled after "Always Show Toolbar in Full Screen" is activated after entering Full Screen

Reported by eviloatm...@gmail.com, Oct 10 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce the problem:
All these steps are in the "View" menu.

1. Deactivate "Always Show Bookmarks Bar"
2. Deactivate "Always Show Toolbar in Full Screen"
3. Activate "Enter Full Screen"
4. Activate "Always Show Toolbar in Full Screen"
5. Notice that "Always Show Bookmarks Bar" is disabled and its active state can't be toggled

What is the expected behavior?

What went wrong?
The "Always Show Bookmarks Bar" option was not enabled after the "Always Show Toolbar in Full Screen" option was activated after activating "Enter Full Screen".

Did this work before? N/A 

Chrome version: 69.0.3497.100  Channel: stable
OS Version: OS X 10.14.0
Flash Version:

Comment 1 by meh...@chromium.org, Oct 10

Components: -UI UI>Browser>FullScreen
Labels: Needs-Feedback
Thanks for the report. Can you reproduce it in latest Canary?

Comment 2 by meh...@chromium.org, Oct 10

Cc: sdy@chromium.org weili@chromium.org
Labels: -Needs-Feedback
Status: Untriaged (was: Unconfirmed)
I reproduce it. Maybe it will be fixed with the issue 831219 ?

Comment 3 by robliao@chromium.org, Oct 11

Labels: Hotlist-DesktopUIConsider

Comment 4 by robliao@chromium.org, Oct 11

Labels: Group-Fullscreen

Comment 5 by robliao@chromium.org, Oct 11

Cc: -sdy@chromium.org
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Routing to sdy@

Comment 6 by robliao@chromium.org, Oct 11

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Comment 7 by weili@chromium.org, Oct 12

Cc: -weili@chromium.org sdy@chromium.org
Owner: weili@chromium.org
Status: Started (was: Assigned)
This should be a simple fix. Since sdy@ is ooo, I can fix this.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b29a855fc7905401af264bb34c4cc56d212f2f22

commit b29a855fc7905401af264bb34c4cc56d212f2f22
Author: Wei Li <weili@chromium.org>
Date: Fri Oct 19 17:21:19 2018

Update browser command states during fullscreen state change

Other than regular fullscreen state changes, there is one more change on
Mac -- turning toolbar always on/off during browser fullscreen mode. In
such case, we need to make sure 'Always Show Bookmarks Bar' should be
enabled/disabled accordingly. This CL triggers browser command update
during such transition.

BUG= 894004 

Change-Id: Ia0a5fb358ca5238492cb8ffca957d10a849ded3c
Reviewed-on: https://chromium-review.googlesource.com/c/1279410
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601200}
[modify] https://crrev.com/b29a855fc7905401af264bb34c4cc56d212f2f22/chrome/browser/ui/browser.cc
[modify] https://crrev.com/b29a855fc7905401af264bb34c4cc56d212f2f22/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc

Comment 9 by weili@chromium.org, Oct 19

Status: Fixed (was: Started)
►

Sign in to add a comment