New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 894001 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Jan 14
Cc:
feuunk@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[AF Wallet] Write integration tests for metadata

Project Member Reported by jkrcal@chromium.org, Oct 10 
When any of the two prefs gets flipped to false, syncing wallet should get disabled:
  autofill::prefs::kAutofillWalletImportEnabled
  autofill::prefs::kAutofillCreditCardEnabled

Similarly, all local data should get wiped (atm with the exception of the Directory copy of sync metadata, should get fixed when we convert metadata to USS).

Comment 1 by jkrcal@chromium.org, Oct 10

Summary: [AF Wallet] Write integration tests for metadata (was: [AF Wallet] Write integration tests for disabling / enabling sync via setting toggles)
Other integrations test to write relate to CL https://chromium-review.googlesource.com/c/chromium/src/+/1273297. We should test this works properly.

Comment 2 by jkrcal@chromium.org, Oct 10

Status: Assigned (was: Untriaged)

Comment 3 by jkrcal@chromium.org, Oct 23

Labels: -Payments-Butter-Cleanups butter-hotlist
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee52a55ade20a84182a463f5e2490082a51e92e9

commit ee52a55ade20a84182a463f5e2490082a51e92e9
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Nov 12 14:08:27 2018

[AF Wallet] Notify remote metadata changes

This CL introduces notification of remote changes for wallet metadata
sync. This is vital for two reasons:
 - PersonalDataManager loads up to date data as soon as it gets changed;
 - It allows to write integration tests for wallet metadata that only
   observe the PDM (and thus test as end-to-end as it gets).

The approach to block self-notification is a bit hacky; it will get
removed in the new USS bridge as this will not listen to MultipleChanged
any more.

Bug:  894001 
Change-Id: I1bcdd4b80187c2980c4343bfd37584ad64d93d01
Reviewed-on: https://chromium-review.googlesource.com/c/1309744
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607215}
[modify] https://crrev.com/ee52a55ade20a84182a463f5e2490082a51e92e9/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/ee52a55ade20a84182a463f5e2490082a51e92e9/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/ee52a55ade20a84182a463f5e2490082a51e92e9/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cde6da1b6c8534b12dbe8ced765651165f2bce2

commit 4cde6da1b6c8534b12dbe8ced765651165f2bce2
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Nov 12 17:29:41 2018

[AF] Add integration tests for wallet metadata

This CL creates the first integration tests for the autofill wallet
metadata model type.

Bug:  894001 
Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23
Reviewed-on: https://chromium-review.googlesource.com/c/1306357
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607282}
[modify] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[add] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[add] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/wallet_helper.cc
[add] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/4cde6da1b6c8534b12dbe8ced765651165f2bce2/chrome/test/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7419fdde22eb141447d7c6192c9d65334bcd774b

commit 7419fdde22eb141447d7c6192c9d65334bcd774b
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Nov 12 22:47:50 2018

Revert "[AF] Add integration tests for wallet metadata"

This reverts commit 4cde6da1b6c8534b12dbe8ced765651165f2bce2.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607282 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGNkZTZkYTFiNmM4NTM0YjEyZGJlOGNlZDc2NTY1MTE2NWYyYmNlMgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/72883

Sample Failed Step: sync_integration_tests

Sample Flaky Test: USS/TwoClientWalletSyncTest.UpdateCreditCardMetadata/1

Original change's description:
> [AF] Add integration tests for wallet metadata
> 
> This CL creates the first integration tests for the autofill wallet
> metadata model type.
> 
> Bug:  894001 
> Change-Id: Ie756264fe6b22d863a6965456ec0d7b627774c23
> Reviewed-on: https://chromium-review.googlesource.com/c/1306357
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607282}

Change-Id: I6021aa4d092acfeb62f635bc04c76b7c11738101
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  894001 ,  904577 
Reviewed-on: https://chromium-review.googlesource.com/c/1332393
Cr-Commit-Position: refs/heads/master@{#607359}
[modify] https://crrev.com/7419fdde22eb141447d7c6192c9d65334bcd774b/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/7419fdde22eb141447d7c6192c9d65334bcd774b/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/7419fdde22eb141447d7c6192c9d65334bcd774b/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[delete] https://crrev.com/5698367bdddad99c17041575f82eab54c200d6a0/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[delete] https://crrev.com/5698367bdddad99c17041575f82eab54c200d6a0/chrome/browser/sync/test/integration/wallet_helper.cc
[delete] https://crrev.com/5698367bdddad99c17041575f82eab54c200d6a0/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/7419fdde22eb141447d7c6192c9d65334bcd774b/chrome/test/BUILD.gn
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c534fb9c77961932d03104aeebf540cdc37f6e

commit 46c534fb9c77961932d03104aeebf540cdc37f6e
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Nov 13 17:42:09 2018

Reland: [AF] Add integration tests for wallet metadata

This CL creates the first integration tests for the autofill wallet
metadata model type.

Bug:  894001 
Change-Id: I55ab6517d03d7ccb199d24ccbbc9ff13927017f0
Reviewed-on: https://chromium-review.googlesource.com/c/1332934
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607638}
[modify] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[add] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[add] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/wallet_helper.cc
[add] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/46c534fb9c77961932d03104aeebf540cdc37f6e/chrome/test/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad793ba03b073e47e865aa2625c9bd12118d6e77

commit ad793ba03b073e47e865aa2625c9bd12118d6e77
Author: Jan Krcal <jkrcal@chromium.org>
Date: Wed Nov 14 16:41:08 2018

[AF] Integration tests for changing additional info for wallet metadata

This CL adds more integration tests; it also fixes a bug that
stopped local changes of billing address and local changes of
has_converted to get propagated to sync.

Bug:  894001 
Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1333819
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608003}
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/ad793ba03b073e47e865aa2625c9bd12118d6e77/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8

commit ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Nov 15 10:56:54 2018

Revert "[AF] Integration tests for changing additional info for wallet metadata"

This reverts commit ad793ba03b073e47e865aa2625c9bd12118d6e77.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 608003 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWQ3OTNiYTAzYjA3M2U0N2U4NjVhYTI2MjVjOWJkMTIxMThkNmU3Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4906

Sample Failed Step: sync_integration_tests on Ubuntu-16.04

Sample Flaky Test: USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1

Original change's description:
> [AF] Integration tests for changing additional info for wallet metadata
> 
> This CL adds more integration tests; it also fixes a bug that
> stopped local changes of billing address and local changes of
> has_converted to get propagated to sync.
> 
> Bug:  894001 
> Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7
> Reviewed-on: https://chromium-review.googlesource.com/c/1333819
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608003}

Change-Id: I6a879efbc643e4aa282ebe8d94c9e43566ab9eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  894001 ,  905606 
Reviewed-on: https://chromium-review.googlesource.com/c/1337631
Cr-Commit-Position: refs/heads/master@{#608311}
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/ed73e0d0a0bb1cd9e0c48fa7a4eb1ff1ff4ce3a8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc

Comment 10 by feuunk@chromium.org, Nov 20

Labels: -butter-hotlist butter-addresses-hotlist

Comment 11 by feuunk@chromium.org, Nov 20

Labels: -M-72 M-73
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16a2137fd554484d9c3f8e44ec143b90c71e8d5

commit f16a2137fd554484d9c3f8e44ec143b90c71e8d5
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Nov 26 14:10:14 2018

Reland: [AF] Integration tests for changing additional info for wallet metadata

This CL adds more integration tests; it also fixes a bug that
stopped local changes of billing address and local changes of
has_converted to get propagated to sync.

Compared to the original CL (patch set 1 here), patch set 2 in this CL
fixes (a) the fixture to make sure PDM converts addresses (a bug
introduced after landing the original CL) and (b) the Checker to wait
until PDM converts remote addresses to local ones (the reason for the
flakiness).

Bug:  894001 
Change-Id: Idf4e87ae36f7ed6348250a5d69bcd66b1f16ec54
Reviewed-on: https://chromium-review.googlesource.com/c/1350614
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610842}
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/chrome/browser/sync/test/integration/wallet_helper.h
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/f16a2137fd554484d9c3f8e44ec143b90c71e8d5/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01059074123d6ab49659f646ec042661b55bab2

commit d01059074123d6ab49659f646ec042661b55bab2
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Dec 03 12:01:01 2018

[AF] Integration tests for wallet metadata involving offline mode

This CL introduces several further integration tests for autofill wallet
metadata. All these tests involve "being offline" which is simulated by
the fake server returning errors.

This CL also changes the behavior in a minor way: it changes merging
two entities that have never been used. The change is non-controversial;
the main motivation for it is to allow writing crisper integration
tests.

Bug:  894001 
Change-Id: I6e29c5ff8f96f6b40bb77f77e881ce1bb3ffbe25
Reviewed-on: https://chromium-review.googlesource.com/c/1335931
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613053}
[modify] https://crrev.com/d01059074123d6ab49659f646ec042661b55bab2/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/d01059074123d6ab49659f646ec042661b55bab2/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/d01059074123d6ab49659f646ec042661b55bab2/components/autofill/core/browser/credit_card.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5afcca7aaf06790c22056e2dfb3b06f2f3db36dd

commit 5afcca7aaf06790c22056e2dfb3b06f2f3db36dd
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Dec 03 16:07:55 2018

[AF] Add an integration tests for conflicting billing address ids

Bug:  894001 
Change-Id: Ia0d5092b6d3dcac8455ee57ebc372ff44b2821d3
Reviewed-on: https://chromium-review.googlesource.com/c/1358439
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613104}
[modify] https://crrev.com/5afcca7aaf06790c22056e2dfb3b06f2f3db36dd/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d0befdf6e03b588241e9df5797ac5bc676d40a4

commit 8d0befdf6e03b588241e9df5797ac5bc676d40a4
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Dec 03 17:52:37 2018

[AF] Use fake time in sync integration tests for wallet metadata

This change makes the tests more robust and easier to read.

Bug:  894001 
Change-Id: I3e147d4384d6119563dd6cf907e024af298ad6a6
Reviewed-on: https://chromium-review.googlesource.com/c/1358504
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613147}
[modify] https://crrev.com/8d0befdf6e03b588241e9df5797ac5bc676d40a4/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16eb38ad60352dbdf7241ebb0f40b546d1197a1

commit f16eb38ad60352dbdf7241ebb0f40b546d1197a1
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Dec 03 21:41:52 2018

[AF] Test that removing wallet data results in removing wallet metadata

This CL adds two more sync integration tests for autofill wallet sync.

Bug:  894001 
Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7
Reviewed-on: https://chromium-review.googlesource.com/c/1358508
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613261}
[modify] https://crrev.com/f16eb38ad60352dbdf7241ebb0f40b546d1197a1/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/f16eb38ad60352dbdf7241ebb0f40b546d1197a1/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/f16eb38ad60352dbdf7241ebb0f40b546d1197a1/chrome/browser/sync/test/integration/wallet_helper.h
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7810b8be795d32099d6589963c0ed8949106bbab

commit 7810b8be795d32099d6589963c0ed8949106bbab
Author: Jeffrey Yasskin <jyasskin@chromium.org>
Date: Fri Dec 07 01:09:58 2018

Revert "[AF] Test that removing wallet data results in removing wallet metadata"

This reverts commit f16eb38ad60352dbdf7241ebb0f40b546d1197a1.

Reason for revert: FindIt says its tests are flaky: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw

Original change's description:
> [AF] Test that removing wallet data results in removing wallet metadata
> 
> This CL adds two more sync integration tests for autofill wallet sync.
> 
> Bug:  894001 
> Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7
> Reviewed-on: https://chromium-review.googlesource.com/c/1358508
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613261}

TBR=sebsg@chromium.org,jkrcal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  894001 ,  911953 
Change-Id: I20bb26bbd973d8ee7411c3269dc4ab6f98e0e272
Reviewed-on: https://chromium-review.googlesource.com/c/1366876
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614528}
[modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/wallet_helper.h
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939d8d1751916c799723256e99aef7e67602e1fb

commit 939d8d1751916c799723256e99aef7e67602e1fb
Author: Jan Krcal <jkrcal@chromium.org>
Date: Wed Dec 12 14:51:41 2018

[AF] Minimize an integration test

This CL removes a server address from an integration test that deals
with server cards. The goal is to (a) keep the tests minimal and (b)
verify that the removed line is causing occasional flakiness of the
test.

Bug:  894001 
Change-Id: Ia773506a051ef4134c37154900c2ffd54ede7048
Reviewed-on: https://chromium-review.googlesource.com/c/1373764
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615884}
[modify] https://crrev.com/939d8d1751916c799723256e99aef7e67602e1fb/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b23f1ad08804f1af9ae41d1c3de02321a8cb064

commit 3b23f1ad08804f1af9ae41d1c3de02321a8cb064
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Dec 18 08:41:40 2018

Reland: [AF] Test that removing wallet data results in removing metadata

This CL adds two more sync integration tests for autofill wallet sync.
A flakiness issue has been solved since the original CL
(https://chromium-review.googlesource.com/c/1358508) got reverted
(https://chromium-review.googlesource.com/c/1366876).

TBR=sebsg@chromium.org

Bug:  894001 
Change-Id: I20a2f7a45bc48f83d7f01e35984f48edf907f055
Reviewed-on: https://chromium-review.googlesource.com/c/1381433
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617416}
[modify] https://crrev.com/3b23f1ad08804f1af9ae41d1c3de02321a8cb064/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
[modify] https://crrev.com/3b23f1ad08804f1af9ae41d1c3de02321a8cb064/chrome/browser/sync/test/integration/wallet_helper.cc
[modify] https://crrev.com/3b23f1ad08804f1af9ae41d1c3de02321a8cb064/chrome/browser/sync/test/integration/wallet_helper.h

Comment 20 by jkrcal@chromium.org, Jan 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment