Issue metadata
Sign in to add a comment
|
Regression: [NTP] Thumbnail titles are seen misplaced on increasing the minimum font size.
Reported by
sanyam.g...@etouch.net,
Oct 10
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.54 (Official Build)Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}(32/64-bit) OS: Windows(7,8,8.1,10). Pre-Condition:1.Enable 'Enable using the Google local NTP','New Tab Page Background Selection' and 'New Tab Page Custom Links' under chrome://flags 2.Apply the theme: https://chrome.google.com/webstore/detail/the-space/nchoeafalnaacdkpoodkjnbogigpjabk?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome, navigate to ‘chrome://settings/fonts’ and change the minimum font size to ‘Huge’. 2. Switch to NTP and observe the thumbnail titles. Actual : Thumbnail titles are seen misplaced on increasing the minimum font size. Expected: Thumbnail titles should not be misplaced on increasing the minimum font size. This is a regression issue, broken in M-70 series, and below is the per-revision-bisect-info Good Build : 70.0.3508.0(Revision:579242) Bad Build : 70.0.3509.0(Revision:579853) You are probably looking for a change made after 579648 (known good), but no later than 579649 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9bbdeeff33929f9aef230b50e8c0bc1076ecd1af..4e973584d96eabe0e57ac6374c4e34abd16ea1fe Suspect: https://chromium.googlesource.com/chromium/src/+/4e973584d96eabe0e57ac6374c4e34abd16ea1fe @sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is also reproducible on M-71 Dev (build # 71.0.3573.0) and M-71 Canary (build # 71.0.3575.0) 2. On Mac(10,12,6, 10.13.1, 10.13.5, 10.14.1),Linux(14.04 LTS)issue is reproducible only before refreshing the page. Kindly review the screen-cast for reference Thank You!
,
Oct 16
Updating to M72
,
Oct 16
,
Nov 9
,
Nov 14
The NextAction date has arrived: 2018-11-14
,
Nov 15
,
Nov 20
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1ac4a78172b6a621a436cc8dcd281ee7ab3c138 commit a1ac4a78172b6a621a436cc8dcd281ee7ab3c138 Author: Kristi Park <kristipark@chromium.org> Date: Mon Nov 26 21:06:35 2018 [NTP] Adjust custom link title style for better truncation and large font sizes Replace "text-shadow" with "filter: drop-shadow()". This lets us remove the manual title truncation and use "text-overflow: ellipsis" instead. Also increase the title container height to 24px in order to allow for larger font sizes. Screencast: https://screencast.googleplex.com/cast/NDgyOTcwNjE2MzU4NTAyNHwyOTk3MzhjZi1iNw Bug: 894000 Change-Id: Ibe46ea6ed269615fb6bf59044ccccce10fd91721 Reviewed-on: https://chromium-review.googlesource.com/c/1337431 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610941} [modify] https://crrev.com/a1ac4a78172b6a621a436cc8dcd281ee7ab3c138/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/a1ac4a78172b6a621a436cc8dcd281ee7ab3c138/chrome/browser/resources/local_ntp/most_visited_single.js
,
Nov 26
,
Nov 28
The NextAction date has arrived: 2018-11-28 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ramyan@chromium.org
, Oct 10Labels: -Pri-1 -Target-70 Pri-2
Owner: kristip...@chromium.org