Binary size check shouldn't run on autoroll CLs |
||||
Issue descriptionPlease see this failed autoroll of V8: https://chromium-review.googlesource.com/c/chromium/src/+/1271791 It included the new android-binary-size trybot which failed, but as far as I understood from the commit message introducing this bot, it shouldn't run for autoroll CLs at all. Please consider with high priority, as rolling V8 is currently blocked by this.
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/37871a022586aa9876e8e1287e598bcf91b0779b commit 37871a022586aa9876e8e1287e598bcf91b0779b Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Oct 10 12:28:08 2018 [release] Ignore binary-size tracking on auto-rolls NOTRY=true Bug: chromium:893991 Change-Id: I490c02266a367d93495a2de7516486aca2c8e26c Reviewed-on: https://chromium-review.googlesource.com/c/1273118 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56524} [modify] https://crrev.com/37871a022586aa9876e8e1287e598bcf91b0779b/tools/release/auto_roll.py [modify] https://crrev.com/37871a022586aa9876e8e1287e598bcf91b0779b/tools/release/test_scripts.py
,
Oct 10
,
Oct 10
Maybe the V8 side CL above for the auto-roll commit message is all that was needed here?
,
Oct 10
The trybot is supposed to whitelist changes where the author contains '-autoroll' but I broke this recently. So the CL in c#2 shouldn't be necessary once https://chromium-review.googlesource.com/c/chromium/src/+/1271791 lands
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bab0fd82fb41367081cd9e0f591f9baf4672650d commit bab0fd82fb41367081cd9e0f591f9baf4672650d Author: Eric Stevenson <estevenson@chromium.org> Date: Wed Oct 10 18:11:13 2018 [size trybot] Fix check for autoroller CLs. Broken by 6c1587f4b1b45fdb672867ec063b19b33edbc027. Bug: 893991 Change-Id: I76d02190a3d0085cff019a706497e0e85d7ed473 Reviewed-on: https://chromium-review.googlesource.com/c/1273264 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#598403} [modify] https://crrev.com/bab0fd82fb41367081cd9e0f591f9baf4672650d/tools/binary_size/trybot_commit_size_checker.py
,
Oct 16
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/71a29af9183e9b21fde2d717241038fd11724c15 commit 71a29af9183e9b21fde2d717241038fd11724c15 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Oct 17 08:07:03 2018 Revert "[release] Ignore binary-size tracking on auto-rolls" This reverts commit 37871a022586aa9876e8e1287e598bcf91b0779b. Reason for revert: Root cause was fixed. Original change's description: > [release] Ignore binary-size tracking on auto-rolls > > NOTRY=true > > Bug: chromium:893991 > Change-Id: I490c02266a367d93495a2de7516486aca2c8e26c > Reviewed-on: https://chromium-review.googlesource.com/c/1273118 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56524} TBR=machenbach@chromium.org,hablich@chromium.org,mslekova@chromium.org NOTRY=true Bug: chromium:893991 Change-Id: I0ac21d38320cefdaf724035d58577dc35315c9eb Reviewed-on: https://chromium-review.googlesource.com/c/1286333 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56712} [modify] https://crrev.com/71a29af9183e9b21fde2d717241038fd11724c15/tools/release/auto_roll.py [modify] https://crrev.com/71a29af9183e9b21fde2d717241038fd11724c15/tools/release/test_scripts.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by mslekova@chromium.org
, Oct 10Owner: agrieve@chromium.org