New issue
Advanced search Search tips

Issue 893959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Disabled 'Add' button and Search icon of 'Add languages' overlay disappears on click outside the overlay

Reported by khushal....@etouch.net, Oct 10

Issue description

Chrome Version: 71.0.3575.0 (Official Build) Revision e76b693f0dd0af3f866de220286b83a2847f0456-refs/branch-heads/3575@{#1} (32/64 bit)
OS: Mac (10.12.6, 10.13.1, 10.14.1), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Steps to reproduce:
1. Launch Google Chrome and navigate to chrome://settings/languages.
2. Click on 'Language' option to expand and then click 'Add languages' option to open it overlay.
3. Now click anywhere outside the overlay and Observe.

Actual Result: Disabled 'Add' button and Search icon of 'Add languages' overlay disappears on click outside the overlay.
Expected Result: Disabled 'Add' button and Search icon should not disappear in any way on click outside the overlay.

This is a Regression issue seen from 'M-71' and below is the manual regression range:
Good Build: 71.0.3570.0 (Revision: 596429)
Bad Build:  71.0.3571.0 (Revision: 596950)

(Unable to provide bisect using Per-revision script as Traceback error message is thrown. Also, tried bisecting on other machines and same error is thrown. Hence, providing suspect using Chromium bisect)

Using Chromium bisect script, providing the bisect info below:-

You are probably looking for a change made after 596870 (known good), but no later than 596918 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/bb250616a7251d105e25d3e9422bb8ab0e6ce087..38a17abcb0954496c6c655388e9d199242a5d725

Suspecting: r596906 ?

@wangxianzhu: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Issue is also seen on M-71 Dev (build #71.0.3573.0).
2. Issue is not seen on Mac (10.13.6) OS and some specific screen resolution for Win OS.

Please refer the attached screen-cast.

Thank You..!!

 
Actual Video.mov
8.6 MB View Download
Expected Video.mov
7.1 MB View Download
The suspected CL seems unrelated to me. The observed behavior seems to me more related low level rendering, like a Blink, Skia issue maybe?
Status: Started (was: Assigned)
I have verified that my CL https://chromium.googlesource.com/chromium/src/+/4b767df9fc88b55eee8c3cffe6245101bd1248e0 caused the regression.
Thanks! It seems the initial comment points to the wrong revision r596906 instead of r596908, but the bug was still assigned to the appropriate author.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b09cd2d6cb27658799f8b672ac499794675a7b87

commit b09cd2d6cb27658799f8b672ac499794675a7b87
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Oct 10 22:09:08 2018

[PE] Reset cached 2d translations when a node becomes the root of 2d translation

Bug:  893959 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9c7336338dfe2e4fa85c85e4bf89e78b49bfa758
Reviewed-on: https://chromium-review.googlesource.com/c/1274194
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598531}
[modify] https://crrev.com/b09cd2d6cb27658799f8b672ac499794675a7b87/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_transform_cache.cc
[modify] https://crrev.com/b09cd2d6cb27658799f8b672ac499794675a7b87/third_party/blink/renderer/platform/graphics/paint/geometry_mapper_transform_cache_test.cc

Status: Fixed (was: Started)

Sign in to add a comment