Issue metadata
Sign in to add a comment
|
"format" dropdown stopped working in layout-test-results/results.html |
||||||||||||||||||||||
Issue descriptionSTEPS: 1. Open layout-test-results/results.html e.g., https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/10452/layout-test-results/results.html 2. Click "in format:" dropdown and change the value. RESULT: Nothing happens. EXPECTED: List is changed to the selected format. NOTE: This used to work, not sure when it stopped working. No errors reported to console.
,
Oct 11
Still reproduces for me on different PC, I'll investigate.
,
Oct 11
I can reproduce this with 71.0.3573.0 on Linux. Mighty strange that this is NG-specific.
,
Oct 11
Also reproducible with my own build from this morning; master at 490d3d816fe11e9b11899d3340f074aa2d11253e, both with chrome and content_shell. Oh, reproducible without LayoutNG enabled too. :)
,
Oct 11
> Oh, reproducible without LayoutNG enabled too. :) Oh...thanks, I should have confirmed that.
,
Oct 11
Caused by https://chromium-review.googlesource.com/c/1215512
,
Oct 11
Issue 894379 has been merged into this issue.
,
Oct 11
,
Oct 11
mstensho@: Could you tell me how did you find this CL is the cause of this issue, please?
,
Oct 11
I found it by bisecting locally.
,
Oct 11
Understood, thanks!
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccdbf121ebade5aee337d4498a6705bc20dee8a6 commit ccdbf121ebade5aee337d4498a6705bc20dee8a6 Author: Yuki Yamada <yukiy@google.com> Date: Thu Oct 11 14:57:11 2018 Add BackupIncumbentScope to set incumbent realm Incumbent realm was not designated for content attribute, so this CL sets event target's realm to incumbent realm. Bug: 893951 Change-Id: If7f526907dae803cd875d70ed79c9ee288df72a9 Reviewed-on: https://chromium-review.googlesource.com/c/1276406 Commit-Queue: Yuki Yamada <yukiy@google.com> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#598762} [modify] https://crrev.com/ccdbf121ebade5aee337d4498a6705bc20dee8a6/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Oct 11
,
Oct 12
,
Oct 12
Issue 894679 has been merged into this issue.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e151e38b3dabf71057cd3f303490937fbc24bad commit 3e151e38b3dabf71057cd3f303490937fbc24bad Author: Yuki Yamada <yukiy@google.com> Date: Fri Oct 12 05:38:24 2018 Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler() This adds a comment for the previous change: https://chromium-review.googlesource.com/c/chromium/src/+/1276406 Bug: 893951 Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c Reviewed-on: https://chromium-review.googlesource.com/c/1278070 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#599104} [modify] https://crrev.com/3e151e38b3dabf71057cd3f303490937fbc24bad/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Oct 12
Thanks for fixing it so quickly!
,
Nov 21
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by atotic@google.com
, Oct 10