New issue
Advanced search Search tips

Issue 893947 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js



Sign in to add a comment

virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js is flaky

Project Member Reported by Findit, Oct 10

Issue description


Flaky test: virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4073f171d02d1c10
Test output log: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/5683
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I7e5eae713e5ad3998b33d953dbf56753819a86ab
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVynwILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLoAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS81NjgzL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzkyYVdSbGJ5MXpkWEptWVdObExXeGhlV1Z5TDJoMGRIQXZkR1Z6ZEhNdlpHVjJkRzl2YkhNdmMyOTFjbU5sY3k5a1pXSjFaMmRsY2kxaWNtVmhhM0J2YVc1MGN5OWljbVZoYTNCdmFXNTBjeTExYVMxcGJpMXRkV3gwYVhCc1pTMTNiM0pyWlhKekxtcHoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVynwILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLoAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS81NjgzL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzkyYVdSbGJ5MXpkWEptWVdObExXeGhlV1Z5TDJoMGRIQXZkR1Z6ZEhNdlpHVjJkRzl2YkhNdmMyOTFjbU5sY3k5a1pXSjFaMmRsY2kxaWNtVmhhM0J2YVc1MGN5OWljbVZoYTNCdmFXNTBjeTExYVMxcGJpMXRkV3gwYVhCc1pTMTNiM0pyWlhKekxtcHoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454

commit ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Oct 10 04:21:57 2018

Revert "Add Picture-in-Picture debugger breakpoints in DevTools."

This reverts commit e01d8c1f7806a56806ac57372e8cbadd1828896d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 598057 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTAxZDhjMWY3ODA2YTU2ODA2YWM1NzM3MmU4Y2JhZGQxODI4ODk2ZAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/5683

Sample Failed Step: webkit_layout_tests on (none) GPU on Mac

Sample Flaky Test: virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/breakpoints-ui-in-multiple-workers.js

Original change's description:
> Add Picture-in-Picture debugger breakpoints in DevTools.
> 
> This CL makes sure enterpictureinpicture, leavepictureinpicture, and
> resize events are listed in a new "Picture-in-Picture" section in the
> Event Listeners Breakpoints panel.
> 
> Screenshot: https://i.imgur.com/7YsiVsb.png
> 
> Change-Id: I7e5eae713e5ad3998b33d953dbf56753819a86ab
> Reviewed-on: https://chromium-review.googlesource.com/c/1261395
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598057}

Change-Id: I915d441aac893247ea4f4ff13a7f1267af4e9576
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  893947 
Reviewed-on: https://chromium-review.googlesource.com/c/1272069
Cr-Commit-Position: refs/heads/master@{#598209}
[modify] https://crrev.com/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/7c05be12be41fd56414d872b1398be63c70de022/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints-expected.txt
[delete] https://crrev.com/7c05be12be41fd56414d872b1398be63c70de022/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints.js
[delete] https://crrev.com/7c05be12be41fd56414d872b1398be63c70de022/third_party/WebKit/LayoutTests/virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/README.txt
[modify] https://crrev.com/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454/third_party/blink/renderer/devtools/front_end/sdk/DOMDebuggerModel.js
[modify] https://crrev.com/ff4a8c01cf386f5cc81de0c1c2e6e1bd36025454/third_party/blink/renderer/devtools/front_end/test_runner/TestRunner.js

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c

commit 2bdcfc79b7cbe59f256b34e6e7df3fff986c517c
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed Oct 10 09:37:39 2018

Reland "Add Picture-in-Picture debugger breakpoints in DevTools."

This is a reland of e01d8c1f7806a56806ac57372e8cbadd1828896d

This CL makes sure video is always playing before requesting PiP in
tests. It also add slow tests detected by findit.

Original change's description:
> Add Picture-in-Picture debugger breakpoints in DevTools.
>
> This CL makes sure enterpictureinpicture, leavepictureinpicture, and
> resize events are listed in a new "Picture-in-Picture" section in the
> Event Listeners Breakpoints panel.
>
> Screenshot: https://i.imgur.com/7YsiVsb.png
>
> Change-Id: I7e5eae713e5ad3998b33d953dbf56753819a86ab
> Reviewed-on: https://chromium-review.googlesource.com/c/1261395
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598057}

Change-Id: I5e728e10e98494c4320358969fe8654a00124276

TBR=dgozman@chromium.org

Bug:  893947 
Change-Id: I5e728e10e98494c4320358969fe8654a00124276
Reviewed-on: https://chromium-review.googlesource.com/c/1272818
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598265}
[modify] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints-expected.txt
[add] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints.js
[add] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/WebKit/LayoutTests/virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/README.txt
[modify] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/blink/renderer/devtools/front_end/sdk/DOMDebuggerModel.js
[modify] https://crrev.com/2bdcfc79b7cbe59f256b34e6e7df3fff986c517c/third_party/blink/renderer/devtools/front_end/test_runner/TestRunner.js

Status: Fixed (was: Untriaged)
Supposed to be fixed.

Sign in to add a comment