New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893945 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Notification counter disappears on lock screen

Project Member Reported by yoshiki@chromium.org, Oct 10

Issue description

Chrome Version: 71.0.3567.0 (Official Build) canary (64-bit)
Platform	11138.0.0 (Official Build) canary-channel eve

What steps will reproduce the problem?
(0) Make sure the experimental lock screen notification feature is off
(1) Show some notifications
(2) Lock the device

What is the expected result?
The notification counter should be placed at the tray even on the lock screen.

What happens instead?
No notification counter at the tray

Please use labels and text to provide additional information.
It had been there, at least before we introduce the unified system tray. Is this change intentional?
 

Comment 1 Deleted

Status: Assigned (was: WontFix)
(Sorry again. The issue is still there. The comment #1 was wrong. Let me remove the comment #1. The experimental flag was enabled when I wrote it)
So, Yamaguchi-san, could you take a look at this? If this change is intended. please close this. Thanks.
Owner: yoshiki@chromium.org
We didn't do anything specific to lockscreen on this icon's class, and had not got the specific spec for this behavior.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155c0b00dea62b3572e729b049d292e131ed6a96

commit 155c0b00dea62b3572e729b049d292e131ed6a96
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Tue Oct 23 02:13:15 2018

Show notification counter even on lock screen

- Unblock notifications in SessionStateNotificationBlocker
- Hide the message center by seeing the session sate (previously, it
  saw the count of notifications)
- Change height below scroll, by checking the visibility of message
  center (previously, it checked only the height)

Bug:  893945 
Test: manual

Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880
Reviewed-on: https://chromium-review.googlesource.com/c/1282426
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601824}
[modify] https://crrev.com/155c0b00dea62b3572e729b049d292e131ed6a96/ash/system/message_center/new_unified_message_center_view.cc
[modify] https://crrev.com/155c0b00dea62b3572e729b049d292e131ed6a96/ash/system/message_center/session_state_notification_blocker.cc
[modify] https://crrev.com/155c0b00dea62b3572e729b049d292e131ed6a96/ash/system/message_center/unified_message_center_view.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3767b2adaecf1079bd957437598440aee49950ac

commit 3767b2adaecf1079bd957437598440aee49950ac
Author: Yoshiki Iguchi <yoshiki@chromium.org>
Date: Tue Oct 23 13:51:19 2018

Revert "Show notification counter even on lock screen"

This reverts commit 155c0b00dea62b3572e729b049d292e131ed6a96.

Reason for revert: This breaks the lock screen notification.

Original change's description:
> Show notification counter even on lock screen
> 
> - Unblock notifications in SessionStateNotificationBlocker
> - Hide the message center by seeing the session sate (previously, it
>   saw the count of notifications)
> - Change height below scroll, by checking the visibility of message
>   center (previously, it checked only the height)
> 
> Bug:  893945 
> Test: manual
> 
> Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880
> Reviewed-on: https://chromium-review.googlesource.com/c/1282426
> Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601824}

TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org

Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  893945 
Reviewed-on: https://chromium-review.googlesource.com/c/1296330
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601930}
[modify] https://crrev.com/3767b2adaecf1079bd957437598440aee49950ac/ash/system/message_center/new_unified_message_center_view.cc
[modify] https://crrev.com/3767b2adaecf1079bd957437598440aee49950ac/ash/system/message_center/session_state_notification_blocker.cc
[modify] https://crrev.com/3767b2adaecf1079bd957437598440aee49950ac/ash/system/message_center/unified_message_center_view.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca86bf3452a5bea83f725a0072c37f9430060105

commit ca86bf3452a5bea83f725a0072c37f9430060105
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Fri Oct 26 11:35:55 2018

Reland "Show notification counter even on lock screen"

This reverts commit 3767b2adaecf1079bd957437598440aee49950ac.

Reason for revert: This CL is innocent. I fixed the issue separately: crrev.com/c/1297853.

Original change's description:
> Revert "Show notification counter even on lock screen"
>
> This reverts commit 155c0b00dea62b3572e729b049d292e131ed6a96.
>
> Reason for revert: This breaks the lock screen notification.
>
> Original change's description:
> > Show notification counter even on lock screen
> >
> > - Unblock notifications in SessionStateNotificationBlocker
> > - Hide the message center by seeing the session sate (previously, it
> >   saw the count of notifications)
> > - Change height below scroll, by checking the visibility of message
> >   center (previously, it checked only the height)
> >
> > Bug:  893945 
> > Test: manual
> >
> > Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880
> > Reviewed-on: https://chromium-review.googlesource.com/c/1282426
> > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#601824}
>
> TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org
>
> Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  893945 
> Reviewed-on: https://chromium-review.googlesource.com/c/1296330
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601930}

TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org


Bug:  893945 
Change-Id: Iaee3fc6e7dcb996be1406897b07f571991a7e3db
Reviewed-on: https://chromium-review.googlesource.com/c/1301037
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603058}
[modify] https://crrev.com/ca86bf3452a5bea83f725a0072c37f9430060105/ash/system/message_center/session_state_notification_blocker.cc

Status: Fixed (was: Assigned)

Sign in to add a comment