New issue
Advanced search Search tips

Issue 893931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 875443



Sign in to add a comment

CrSettingsSiteListEntryTest.All fails with Polymer 2

Project Member Reported by rbpotter@chromium.org, Oct 10

Issue description

This test is currently failing when run with --enable-features=WebUIPolymer2. It needs to be fixed and added to the list of passing tests in testing/buildbot/filters/webui_polymer2_browser_tests.filter.

 
Blocking: 875443
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb3dd8bbd1f78c983cfef0a83084718c8f1037a0

commit eb3dd8bbd1f78c983cfef0a83084718c8f1037a0
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 10 21:26:00 2018

Settings UI: Fix tests to work with Polymer 2

Fixing CrSettingsSiteListEntryTest.All to work with Polymer 2.

Also fixing CrSettingsPrivacyPageTest on non-Mac platforms. This test
was excluded twice, once in the filter file (for all platforms) and
in the test file itself (for Mac only). While being excluded for Mac
failures, it appears some new failures started occurring on other
platforms. These failures are addressed in this CL, and the test is
removed from the filter file. It remains disabled on Mac, which is
tracked by  https://crbug.com/877109 .

Bug:  893931 
Change-Id: I8a55de82677b1d682acc267277fe16e943bf93b7
Reviewed-on: https://chromium-review.googlesource.com/c/1272802
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598513}
[modify] https://crrev.com/eb3dd8bbd1f78c983cfef0a83084718c8f1037a0/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/eb3dd8bbd1f78c983cfef0a83084718c8f1037a0/chrome/test/data/webui/settings/site_list_entry_tests.js
[modify] https://crrev.com/eb3dd8bbd1f78c983cfef0a83084718c8f1037a0/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81ced897b0ae63f6aeb3d15e4626d74ba331c594

commit 81ced897b0ae63f6aeb3d15e4626d74ba331c594
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Oct 11 22:55:40 2018

Add CrSettingsSiteListEntryTest to the white list

https://crrev.com/c/1272802 fixed this test and removed it from the
blacklist but neglected to add it to the whitelist.

Bug:  893931 
Change-Id: I68e8b220ab75b9b2c6eb3e5bbeb6457d3fb36aaf
Reviewed-on: https://chromium-review.googlesource.com/c/1277821
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598994}
[modify] https://crrev.com/81ced897b0ae63f6aeb3d15e4626d74ba331c594/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Sign in to add a comment