Seems like this is complete but the div lines between the cards aren't consistent with Snowflakes styles (we don't use div lines between cards and list items, as the cards already have boundaries, and list items already have titles). Would we be able to remove them in time for 100% Stable?
Sorry for the nit, but that shows the separators being removed in between dates. They are also there (sightly different - 16dp margin, 1dp stroke IIRC) for different file type headers within the same date (that particular scenario isn't present in that mock). You want those removed as well right?
Synced with Hannah, here's the plan (not critical for M71 since branch was yesterday):
Keep dividers between dates, use snowflake divider (1dp)
Remove the dividers between different file types
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!
If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.
Thanks for your time! To disable nags, add the Disable-Nags label.
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by hannahs@google.com
, Oct 11