New issue
Advanced search Search tips

Issue 893918 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Participants' hotlists:
Downloads-Home-Rework


Sign in to add a comment

[Downloads home] Card styles need to be snowflake compliant

Project Member Reported by nancygao@chromium.org, Oct 10

Issue description

Card layout on DH should be snowflake compliant, spec TBD by Hannah. This will occur as a fast follow to DH launch in M71.
 
Seems like this is complete but the div lines between the cards aren't consistent with Snowflakes styles (we don't use div lines between cards and list items, as the cards already have boundaries, and list items already have titles). Would we be able to remove them in time for 100% Stable?
Just to confirm, is this for all dividers or only those between sections?  There are dividers in between each file type section as well as in between each date.

https://docs.google.com/presentation/d/14pBMf4Qrhd_a4qF6KdXJJfAZYLdmv_JN0gL8GC4SWAU/edit?pli=1#slide=id.g3c6547ca53_18_0
proposed update attached
Screen Shot 2018-10-11 at 12.49.12 PM.png
389 KB View Download
Sorry for the nit, but that shows the separators being removed in between dates. They are also there (sightly different - 16dp margin, 1dp stroke IIRC) for different file type headers within the same date (that particular scenario isn't present in that mock).  You want those removed as well right?
Amy - Does this change sound good to you?  Thanks!
Status: Assigned (was: Untriaged)
Synced with Hannah, here's the plan (not critical for M71 since branch was yesterday):

Keep dividers between dates, use snowflake divider (1dp)
Remove the dividers between different file types

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e736bc34f843037e2fbe89449aa06790c1c0b2

commit 64e736bc34f843037e2fbe89449aa06790c1c0b2
Author: David Trainor <dtrainor@chromium.org>
Date: Tue Oct 16 00:10:24 2018

Remove separators in new Downloads Home v2

Remove date and filter type separators from the new downloads home UI.

BUG=893918

Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59
Reviewed-on: https://chromium-review.googlesource.com/c/1277967
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599791}
[delete] https://crrev.com/aa055e655117238554d89ad4d411e54bfa6028bc/chrome/android/java/res_download/layout/download_manager_date_separator.xml
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/res_download/layout/download_manager_section_header.xml
[delete] https://crrev.com/aa055e655117238554d89ad4d411e54bfa6028bc/chrome/android/java/res_download/layout/download_manager_section_separator.xml
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutator.java
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListItem.java
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListUtils.java
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ListItemViewHolder.java
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SectionTitleViewHolder.java
[delete] https://crrev.com/aa055e655117238554d89ad4d411e54bfa6028bc/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SeparatorViewHolder.java
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/java_sources.gni
[modify] https://crrev.com/64e736bc34f843037e2fbe89449aa06790c1c0b2/chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java

Labels: Merge-Request-71
Requesting Merge to M-71.  UI code that is behind a feature flag.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 22

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b63dff893896881500aa907c0d271db1ad234e60

Commit: b63dff893896881500aa907c0d271db1ad234e60
Author: dtrainor@chromium.org
Commiter: dtrainor@chromium.org
Date: 2018-10-24 16:22:46 +0000 UTC

Remove separators in new Downloads Home v2

Remove date and filter type separators from the new downloads home UI.

BUG=893918

Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59
Reviewed-on: https://chromium-review.googlesource.com/c/1277967
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599791}(cherry picked from commit 64e736bc34f843037e2fbe89449aa06790c1c0b2)
Reviewed-on: https://chromium-review.googlesource.com/c/1298118
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#292}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63dff893896881500aa907c0d271db1ad234e60

commit b63dff893896881500aa907c0d271db1ad234e60
Author: David Trainor <dtrainor@chromium.org>
Date: Wed Oct 24 16:22:46 2018

Remove separators in new Downloads Home v2

Remove date and filter type separators from the new downloads home UI.

BUG=893918

Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59
Reviewed-on: https://chromium-review.googlesource.com/c/1277967
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599791}(cherry picked from commit 64e736bc34f843037e2fbe89449aa06790c1c0b2)
Reviewed-on: https://chromium-review.googlesource.com/c/1298118
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#292}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[delete] https://crrev.com/4467858024735cdf0091ef6d12b835fdb305c00f/chrome/android/java/res_download/layout/download_manager_date_separator.xml
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/res_download/layout/download_manager_section_header.xml
[delete] https://crrev.com/4467858024735cdf0091ef6d12b835fdb305c00f/chrome/android/java/res_download/layout/download_manager_section_separator.xml
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutator.java
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListItem.java
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListUtils.java
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ListItemViewHolder.java
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SectionTitleViewHolder.java
[delete] https://crrev.com/4467858024735cdf0091ef6d12b835fdb305c00f/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SeparatorViewHolder.java
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/java_sources.gni
[modify] https://crrev.com/b63dff893896881500aa907c0d271db1ad234e60/chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java

Sign in to add a comment