[Downloads home] Update chips in DH |
||||||
Issue descriptionChips style needs to be updated (spec TBD from Hannah) as a fast follow to downloads home launch
,
Oct 11
Also, please note that the hairline stroke should be an inner outline so that it's the same size as the selected chip. (The current Canary build seems like it's an outer outline).
,
Oct 11
Hannah could we update those specs to include of chips with icons? I just want to make sure I have all of the padding right. Thanks! I can definitely update the left padding today.
,
Oct 12
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32e4962e1ede46d0938db54b9285b5e43266814f commit 32e4962e1ede46d0938db54b9285b5e43266814f Author: David Trainor <dtrainor@chromium.org> Date: Tue Oct 16 17:06:50 2018 Update chip styles to snowflake approved values Update the chip colors/styles to be the snowflake approved styles. This currently includes changing the background color, the text color and the stroke color for chip states. This patch also updates the padding for the chip list in downloads home v2 to match spec. BUG= 893915 Change-Id: I7f298542cbe630f6d6b2f02f104b4b5f71f0ba85 Reviewed-on: https://chromium-review.googlesource.com/c/1278987 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600021} [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res/color/chip_background_color.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res/color/chip_stroke_color.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res/drawable/flush_footer_button.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res/drawable/hairline_border_card_background.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsCoordinator.java [modify] https://crrev.com/32e4962e1ede46d0938db54b9285b5e43266814f/ui/android/java/res/values/colors.xml
,
Oct 17
Requesting Merge to M-71. UI code that is behind a feature flag.
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771222f5714ba1d83932ea95b51d6f8ebb410b7f commit 771222f5714ba1d83932ea95b51d6f8ebb410b7f Author: David Trainor <dtrainor@chromium.org> Date: Wed Oct 24 17:04:34 2018 Update chip styles to snowflake approved values Merge to Release Branch: 3578 Update the chip colors/styles to be the snowflake approved styles. This currently includes changing the background color, the text color and the stroke color for chip states. This patch also updates the padding for the chip list in downloads home v2 to match spec. BUG= 893915 TBR=dtrainor@chromium.org (cherry picked from commit 32e4962e1ede46d0938db54b9285b5e43266814f) Change-Id: I7f298542cbe630f6d6b2f02f104b4b5f71f0ba85 Reviewed-on: https://chromium-review.googlesource.com/c/1278987 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600021} Reviewed-on: https://chromium-review.googlesource.com/c/1298127 Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#294} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/res/color/chip_background_color.xml [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/res/color/chip_stroke_color.xml [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/res/drawable/flush_footer_button.xml [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/res/drawable/hairline_border_card_background.xml [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsCoordinator.java [modify] https://crrev.com/771222f5714ba1d83932ea95b51d6f8ebb410b7f/ui/android/java/res/values/colors.xml
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771222f5714ba1d83932ea95b51d6f8ebb410b7f Commit: 771222f5714ba1d83932ea95b51d6f8ebb410b7f Author: dtrainor@chromium.org Commiter: dtrainor@chromium.org Date: 2018-10-24 17:04:34 +0000 UTC Update chip styles to snowflake approved values Merge to Release Branch: 3578 Update the chip colors/styles to be the snowflake approved styles. This currently includes changing the background color, the text color and the stroke color for chip states. This patch also updates the padding for the chip list in downloads home v2 to match spec. BUG= 893915 TBR=dtrainor@chromium.org (cherry picked from commit 32e4962e1ede46d0938db54b9285b5e43266814f) Change-Id: I7f298542cbe630f6d6b2f02f104b4b5f71f0ba85 Reviewed-on: https://chromium-review.googlesource.com/c/1278987 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600021} Reviewed-on: https://chromium-review.googlesource.com/c/1298127 Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#294} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 31
Apologies for the delay but I've just uploaded the specs for the hover and dark themes here: https://drive.google.com/open?id=1EyhN24a3pfDatfdYIgoU30tGDxkLAqZn Do you think we can update this by EoY? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hannahs@google.com
, Oct 1149.2 KB
49.2 KB View Download