New issue
Advanced search Search tips

Issue 893880 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Oct 15
Cc:
chiniforooshan@chromium.org
frechette@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.9% regression in system_health.common_desktop at 597468:597469

Project Member Reported by m...@chromium.org, Oct 9 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 9 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=893880

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6c2036d99f9f8746ed797d51b7a86fcbfa63aed70559ec87056ca6b23b6bc06d


Bot(s) for this bug's original alert(s):

linux-perf

system_health.common_desktop - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 10 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/17b107d8e40000

Comment 5 by m...@chromium.org, Oct 10

Cc: -m...@chromium.org
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 10

Cc: frechette@chromium.org
Owner: frechette@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/13340e32e40000

Revert "[Language] Do not show translation offer prompt when CLD and html/content" by frechette@chromium.org
https://chromium.googlesource.com/chromium/src/+/89d6f0d7ea7982e72db195523356338171977c49
cpu_time_percentage: 0.067 → 0.07035 (+0.003354)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks

Comment 7 by frechette@chromium.org, Oct 14

Cc: chiniforooshan@chromium.org
 Issue 892783  has been merged into this issue.

Comment 8 by frechette@chromium.org, Oct 15

Status: WontFix (was: Assigned)
A revert cannot cause a (meaningful) regression.

Comment 10 by frechette@chromium.org, Oct 15

Owner: ----
Status: Available (was: WontFix)

Comment 11 by chiniforooshan@chromium.org, Oct 15 

True. Thanks @frechette.

I noticed that after the revert (i.e. commit 597467), the metric value is higher than what it was before the reverted CL (i.e. commit 594323). So, something in between must regressed the metric. From the graph, I guess it should be around Oct 2.

I'll start another pinpoint job. If it doesn't find anything, I'll mark as won't fix since the regression is small.

Comment 12 by chiniforooshan@chromium.org, Oct 15

Status: Untriaged (was: Available)
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Oct 15 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/16bf0912e40000
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Oct 15 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/13e2da82e40000

Comment 16 by chiniforooshan@chromium.org, Oct 15

Status: WontFix (was: Untriaged)
►

Sign in to add a comment