New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893878 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Fix flaky MultiDevice-related KeyedService tests

Project Member Reported by khorimoto@chromium.org, Oct 9

Issue description

As part of [1], I set several flags to enabled by default. Due to this change, several KeyedServices (TetherService, AndroidSmsService, etc.) were created when they previously were not, resulting in crashes in many browser_tests. See [2] for an example CQ run with these failing tests.

To fix this, I overrode the ServiceIsNULLWhileTesting() function for several of these KeyedServices to ensure that they are not created during browser_tests. Unfortunately, this breaks some of our own tests (e.g., TetherService.TestGet_PrimaryUser_FeatureFlagEnabled), which rely on the Get() functionality returning a real KeyedService.

I've temporarily disabled some of these tests, and we should fix and re-enable these post-launch.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1260491
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/110588
 

Sign in to add a comment