Issue metadata
Sign in to add a comment
|
4.2%-100% regression in rendering.mobile/thread_total_all_cpu_time_per_frame at 597107:597393 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 9
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/110e2172e40000
,
Oct 9
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/110e2172e40000
,
Oct 10
Noisy graphs for this benchmark, triggering alerts and failed bisects. Assigning to owner to fix.
,
Oct 10
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15688b2ee40000
,
Oct 10
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/121e348ee40000
,
Oct 10
I think the alert point wasn't accurate enough to generate a good range for pinpoint. There seem to be two regressions, before and after the range that got bisected in #3. Graphs: https://chromeperf.appspot.com/report?sid=a272b731ecf48253fcb596409a221128905fd0b293bfa9fa11fcb33bf244a12f #5 triggers a bisect on 'thread_browser_cpu_time_per_frame' in range 597107-597166. #6 triggers a bisect on 'thread_other_cpu_time_per_frame' in range 597366 - 597393.
,
Oct 10
,
Oct 10
The first one is likely crrev.com/597137, which is expected to increase cpu-usage a bit since we are dispatching more events, and thus doing more work, per frame. The second is likely crrev.com/597373.
,
Oct 10
> The second is likely crrev.com/597373. Hmm, we need to revert DSF enablement on Android too then.
,
Oct 11
#11: A proper fix for the solid color quads regression is almost ready (issue 879379), so I don't think we need to revert the dsf change.
,
Oct 11
M71 is branching tomorrow. We need to adhere to principles of revert first, fix later.
,
Oct 11
,
Oct 11
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/121e348ee40000 Revert "solid color quads workaround for use-zoom-for-dsf" by eirage@chromium.org https://chromium.googlesource.com/chromium/src/+/d7d5990bc6b25d7b7ce711b035147030e778879a thread_other_cpu_time_per_frame: 7.646 → 8.207 (+0.5608) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/rendering-benchmarks
,
Oct 11
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/15688b2ee40000 Reland "synthetic gesture: Allow high-frequency dispatch." by sadrul@chromium.org https://chromium.googlesource.com/chromium/src/+/a66784e0fd71f686f1d7152902137619608c6c80 thread_browser_cpu_time_per_frame: 2.224 → 2.411 (+0.1868) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/rendering-benchmarks
,
Oct 11
Issue 893862 has been merged into this issue.
,
Oct 11
Issue 893596 has been merged into this issue.
,
Oct 11
The regression caused by reverting the workaround should be fixed by https://chromium.googlesource.com/chromium/src/+/159ad145dd83238fb3d27e709205f9a5cec84be3
,
Oct 12
I see a dip in https://chromeperf.appspot.com/group_report?bug_id=893860 for thread_total_all_cpu_time_per_frame. It'd be interesting to see if it persists.
,
Oct 12
Yeah, CPU times are back down. Other examples: https://chromeperf.appspot.com/report?sid=49819f8b6a1b198cc20a09360e425f1fb5c447f5c28fdbb52b91c3264ffa95fa I'm a bit concerned that we may have regressed GPU power especially on CrOS, because now we are not creating smaller quads that can be culled.
,
Oct 12
Related benchmark drop back after Yi's change. (some of them are even better than before :D) Thanks Yi!
,
Oct 22
Issue 893178 has been merged into this issue.
,
Oct 25
Issue 871347 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 9