New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893850 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 893731



Sign in to add a comment

Eliminiate Extraneous IPCs for surface creation and activation

Project Member Reported by fsam...@chromium.org, Oct 9

Issue description

Surface synchronization and OOP-D introduce a number of additional IPCs on scrolling away top bar controls such as OnSurfaceCreated and OnFirstSurfaceActivation. We should eliminate these unnecessary overheads.
 
Blockedon: 893731
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be07029b7416d3e899eeab2fdd0c8702c09b5af6

commit be07029b7416d3e899eeab2fdd0c8702c09b5af6
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Oct 10 21:51:33 2018

viz: Remove temporary reference ownership

Temporary reference ownership exists to allow us to invalidate temporary
references if an 'owner' of the reference goes away prematurely.

This mechanism exists in addition to temporary reference expiry. However,
it incurs a significant overhead through IPCs from viz to viz host and
back. This CL removes that feature in an attempt to improve scrolling
performance on Android when surface sync is enabled.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I67c3d4edba93e432d25b648f913c1c32367f8c18
Bug: 893850
TBR: ericrk@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1259470
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598526}
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/ash/ash_service.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/test/BUILD.gn
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/components/viz/test/test_frame_sink_manager.h
[delete] https://crrev.com/5fd1898e10f8626fb5a1f3ae161b8f2c115bf39d/components/viz/test/test_frame_sink_manager_client.cc
[delete] https://crrev.com/5fd1898e10f8626fb5a1f3ae161b8f2c115bf39d/components/viz/test/test_frame_sink_manager_client.h
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[modify] https://crrev.com/be07029b7416d3e899eeab2fdd0c8702c09b5af6/ui/android/delegated_frame_host_android.cc

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16c116bce40000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a3d4ca185aa50f8522397327f3edaf2cbf2268

commit 47a3d4ca185aa50f8522397327f3edaf2cbf2268
Author: Fady Samuel <fsamuel@chromium.org>
Date: Fri Oct 12 15:23:47 2018

Surface Synchronization: optionally report FirstSurfaceActivation

With SurfaceRanges, clients will soon no longer need FirstSurfaceActivation
messages in order to update fallbacks.

The ultimate end state of this work is to save an IPC on scroll on Android
when showing/hiding top bar controls. This should allow for a smoother
scroll experience (yay!).

This CL introduces a new parameter to RegisterFrameSinkId that allows
the client to decide whether or not it's interested in FirstSurfaceActivation.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6a085f4ed910ef6997af67f63e47e85a05b41dd6
Bug: 893850
Reviewed-on: https://chromium-review.googlesource.com/c/1277375
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599224}
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/service/frame_sinks/video_detector_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/components/viz/test/test_frame_sink_manager.h
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/browser/renderer_host/embedded_frame_sink_impl.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/content/test/test_render_view_host.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/services/ws/client_root.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/services/ws/window_tree_unittest.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/47a3d4ca185aa50f8522397327f3edaf2cbf2268/ui/compositor/compositor.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35

commit 0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35
Author: kylechar <kylechar@chromium.org>
Date: Mon Oct 15 17:49:52 2018

Remove namespace test in components/viz/*

Delete some usage of "namespace test" in components/viz/* that got added
back in the year or so since we originally decided to not use it.

Bug: 893850
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic4a0c134c6c7dd66d4f1eb89526155111c1f2a10
Reviewed-on: https://chromium-review.googlesource.com/c/1276546
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599673}
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/gl/gpu_service_impl_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/surfaces/referenced_surface_tracker_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/surfaces/surface_dependency_deadline_unittest.cc
[modify] https://crrev.com/0ff74176b7a3ebc0f4c9e824718b2bcc8c416e35/components/viz/service/surfaces/surface_manager.h

Summary: Eliminiate Extraneous IPCs during scroll (was: Eliminiate Extraneous IPCs during scroll on Android)
Summary: Eliminiate Extraneous IPCs for surface creation and activation (was: Eliminiate Extraneous IPCs during scroll)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b

commit 0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Oct 22 16:09:09 2018

Surface Synchronization: Remove Mac FirstSurfaceActivation path

Mac no longer needs FirstSurfaceActivation notification so this CL
saves an IPC and deletes some unnecessary plumbing.

Bug: 893850
Change-Id: Ie8fceb0de65ff9148ff349e8c298eb20be6aa7b5
Reviewed-on: https://chromium-review.googlesource.com/c/1292261
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601601}
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/delegated_frame_host_client_aura.cc
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/delegated_frame_host_client_aura.h
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/0dce6ad3dcd63deecbb6b0fd36976e3c58b8074b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069af228430e7d140193d71669f551f0cd83d2b9

commit 069af228430e7d140193d71669f551f0cd83d2b9
Author: Saman Sami <samans@chromium.org>
Date: Mon Oct 22 16:57:45 2018

Don't report OnFirstSurfaceActivation to CompositorImpl

Bug: 893850
Change-Id: Icb5d59ac7dd6a6cf1dfd6e17f913966d6d546c29
Reviewed-on: https://chromium-review.googlesource.com/c/1294012
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601616}
[modify] https://crrev.com/069af228430e7d140193d71669f551f0cd83d2b9/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/069af228430e7d140193d71669f551f0cd83d2b9/content/browser/renderer_host/compositor_impl_android.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd538eb3daf6c52d3ebef0a7afea758f6c657c8

commit dcd538eb3daf6c52d3ebef0a7afea758f6c657c8
Author: Saman Sami <samans@chromium.org>
Date: Mon Oct 22 17:25:03 2018

Don't report OnFirstSurfaceActivation for ui::Compositor

Bug: 893850
Change-Id: Iee754cefbd083d0a21a2b672fb8e837eaab81c43
Reviewed-on: https://chromium-review.googlesource.com/c/1293712
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601629}
[modify] https://crrev.com/dcd538eb3daf6c52d3ebef0a7afea758f6c657c8/ui/compositor/compositor.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403f15b64b70b73f95c24967af962c15ab419a84

commit 403f15b64b70b73f95c24967af962c15ab419a84
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Oct 29 21:20:15 2018

viz: Remove SurfaceManager::DropTemporaryReference

It's no longer used.

Bug: 893850
Change-Id: Ibbd613affd364dac728cf00230e0b017dde7d70f
Reviewed-on: https://chromium-review.googlesource.com/c/1305882
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603630}
[modify] https://crrev.com/403f15b64b70b73f95c24967af962c15ab419a84/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/403f15b64b70b73f95c24967af962c15ab419a84/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/403f15b64b70b73f95c24967af962c15ab419a84/tools/metrics/histograms/enums.xml

Cc: fsam...@chromium.org
Owner: samans@chromium.org
Passing along to samans@
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f538cffc7ef006234a6beae7e2411ca49d4c30

commit d2f538cffc7ef006234a6beae7e2411ca49d4c30
Author: Saman Sami <samans@chromium.org>
Date: Mon Nov 19 22:24:59 2018

Stop sending OnFirstSurfaceActivation to SurfaceLayerBridge

Establish a direct connection from the child (CanvasResourceDispatcher/
VideoFrameSubmitter) to the embedder (SuraceLayerBridge) so the child
can notify the embedder of its allocated SurfaceIds directly instead of
three process hops (renderer->viz->browser->renderer), hence reducing
latency and eliminating any IPC messages involved in this process.

Bug: 893850,883927
Change-Id: Ide595e3c6aa995c77678d6413d5ad6421e2d35e5
Reviewed-on: https://chromium-review.googlesource.com/c/1338411
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609469}
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/content/browser/renderer_host/embedded_frame_sink_impl.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/content/browser/renderer_host/embedded_frame_sink_impl.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/content/browser/renderer_host/embedded_frame_sink_provider_impl.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/content/browser/renderer_host/embedded_frame_sink_provider_impl.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/content/browser/renderer_host/embedded_frame_sink_provider_impl_unittest.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/public/platform/modules/frame_sinks/embedded_frame_sink.mojom
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/begin_frame_provider.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/test/mock_embedded_frame_sink_provider.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/d2f538cffc7ef006234a6beae7e2411ca49d4c30/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8fc00a7dc30976844ae21b619c63d8aa4e4b733

commit c8fc00a7dc30976844ae21b619c63d8aa4e4b733
Author: Saman Sami <samans@chromium.org>
Date: Mon Nov 19 23:16:35 2018

Remove unnecessary calls to SetOldestAcceptableFallback

We only need to call this method during main frame navigation.

TBR=apacible@chromium.org

Bug: 893850
Change-Id: Id78fb02440f646c07de9bec3460cbb64809781f1
Reviewed-on: https://chromium-review.googlesource.com/c/1340702
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609493}
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/content/browser/picture_in_picture/overlay_surface_embedder.cc
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/c8fc00a7dc30976844ae21b619c63d8aa4e4b733/ui/aura/mus/client_surface_embedder.cc

Sign in to add a comment