New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893848 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

A zero-to-nonzero regression in rendering.mobile/mean_pixels_approximated at 596998:597024

Project Member Reported by m...@chromium.org, Oct 9

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=893848

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cb38993c68c1c2561627fb99fc33fc349ce958141e2849279e0b7c6dc32e32d3


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: chromium...@skia-public.iam.gserviceaccount.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12ee7b54e40000

Roll src/third_party/catapult a7a24422d086..56216d7832a4 (1 commits) by chromium-autoroll@skia-public.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/84f9167ca06c316950a8f0eb12d6d55244769859
mean_pixels_approximated: 0 → 5.861e-05 (+5.861e-05)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Owner: sullivan@chromium.org
According to the CL description, I'm supposed to assign to sullivan@. (The TBR reviewer on the roll.)
 Issue 893851  has been merged into this issue.
Owner: chiniforooshan@chromium.org
Ehsan: The only CL in the roll is:
2018-10-05 chiniforooshan@chromium.org Telemetry: pixel approximated/checkerboarded

Can you take a look?
Status: Started (was: Assigned)
Cc: vmi...@chromium.org
Status: WontFix (was: Started)
I think the zero to non-zero issue happens because the old code was rounding off values to 3 decimal digits:

https://chromium-review.googlesource.com/c/catapult/+/1262018/8/telemetry/telemetry/web_perf/metrics/rendering_stats.py#b272

The new TBMv2 version reports exact values. Given this, I think this is not a real regression and we can safely ignore (CCing @vmiura to reopen if rounding had a good reason that I ignored).

Sign in to add a comment