[EoS] Implement site blocking |
|||||||
Issue descriptionThe user can chose to remove a site (blacklist it) from the list of Explore on Sites (EoS) recommendations. We have the menu item on the EoS page, but we need to hook it up to actually remove the site. This includes adding the site to the blacklist table in the database, removing from the view, removing from the model, replacing the site with another (if there are more than 8 available), and ensuring that we don't display sites in the blacklist for future openings of the EoS page.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da6c8bfcbd9edb1a2dfa29642124c3b762c05894 commit da6c8bfcbd9edb1a2dfa29642124c3b762c05894 Author: Pete Williamson <petewil@chromium.org> Date: Fri Oct 12 19:43:11 2018 [EoS] Site blacklisting part 2 Make sure sites in the blacklist are not returned as part of a catalog get operation. This builds upon Site blacklisting part 1. Bug: 893845 Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31 Reviewed-on: https://chromium-review.googlesource.com/c/1274058 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599325} [modify] https://crrev.com/da6c8bfcbd9edb1a2dfa29642124c3b762c05894/chrome/browser/android/explore_sites/get_catalog_task.cc [modify] https://crrev.com/da6c8bfcbd9edb1a2dfa29642124c3b762c05894/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a564f6e01d3486288673b7f63e679e004108f067 commit a564f6e01d3486288673b7f63e679e004108f067 Author: Pete Williamson <petewil@chromium.org> Date: Sat Oct 13 00:24:27 2018 [EoS] Site Blacklisting part 3 - Remove sites from the UI. When the user chooses the "remove" item from the long press menu, remove the site from the UI. It is already being removed from the database. Bug: 893845 Change-Id: Icbd8292475983f4c263113043a001d11f3f09521 Reviewed-on: https://chromium-review.googlesource.com/c/1278955 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599438} [modify] https://crrev.com/a564f6e01d3486288673b7f63e679e004108f067/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java [modify] https://crrev.com/a564f6e01d3486288673b7f63e679e004108f067/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f3e4589bce29e58ca0c2df2285374087881da9 commit f5f3e4589bce29e58ca0c2df2285374087881da9 Author: Pete Williamson <petewil@chromium.org> Date: Tue Oct 16 17:52:23 2018 [EoS] Fix the blacklist application Some sites were being added to the blacklist properly, but not filtered out when doing the join against the blacklist table. This happened because the sites in our database did not consistently end with "/", but sometimes a "/" got added before we put the site into the blacklist. The fix here is to pass all sites through GURL and get the spec after parsing, so they will be consistent. Bug: 893845 Change-Id: Id705aab833da546c57950fad115c694b96c5fd24 Reviewed-on: https://chromium-review.googlesource.com/c/1281176 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#600037} [modify] https://crrev.com/f5f3e4589bce29e58ca0c2df2285374087881da9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTask.java [modify] https://crrev.com/f5f3e4589bce29e58ca0c2df2285374087881da9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java [modify] https://crrev.com/f5f3e4589bce29e58ca0c2df2285374087881da9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/f5f3e4589bce29e58ca0c2df2285374087881da9/chrome/browser/android/explore_sites/explore_sites_service_impl.cc [modify] https://crrev.com/f5f3e4589bce29e58ca0c2df2285374087881da9/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
,
Oct 17
I request merging changelists 2, 3, and 4 in this bug into M71 branch. They have been tested in Canary.
,
Oct 19
,
Oct 20
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d29132bf8dc021f7fbb964c7917523971d7af6e8 commit d29132bf8dc021f7fbb964c7917523971d7af6e8 Author: Pete Williamson <petewil@chromium.org> Date: Mon Oct 22 16:25:24 2018 [EoS] Site blacklisting part 2 Make sure sites in the blacklist are not returned as part of a catalog get operation. This builds upon Site blacklisting part 1. Bug: 893845 Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31 Reviewed-on: https://chromium-review.googlesource.com/c/1274058 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599325}(cherry picked from commit da6c8bfcbd9edb1a2dfa29642124c3b762c05894) Reviewed-on: https://chromium-review.googlesource.com/c/1293993 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#213} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/d29132bf8dc021f7fbb964c7917523971d7af6e8/chrome/browser/android/explore_sites/get_catalog_task.cc [modify] https://crrev.com/d29132bf8dc021f7fbb964c7917523971d7af6e8/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814 commit 3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814 Author: Pete Williamson <petewil@chromium.org> Date: Mon Oct 22 16:26:25 2018 [EoS] Site Blacklisting part 3 - Remove sites from the UI. When the user chooses the "remove" item from the long press menu, remove the site from the UI. It is already being removed from the database. Bug: 893845 Change-Id: Icbd8292475983f4c263113043a001d11f3f09521 Reviewed-on: https://chromium-review.googlesource.com/c/1278955 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599438}(cherry picked from commit a564f6e01d3486288673b7f63e679e004108f067) Reviewed-on: https://chromium-review.googlesource.com/c/1294013 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#214} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java [modify] https://crrev.com/3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b102f4d05e81d8673b5ad284bc734d9d99549d9 commit 9b102f4d05e81d8673b5ad284bc734d9d99549d9 Author: Pete Williamson <petewil@chromium.org> Date: Mon Oct 22 16:27:14 2018 [EoS] Fix the blacklist application Some sites were being added to the blacklist properly, but not filtered out when doing the join against the blacklist table. This happened because the sites in our database did not consistently end with "/", but sometimes a "/" got added before we put the site into the blacklist. The fix here is to pass all sites through GURL and get the spec after parsing, so they will be consistent. Bug: 893845 Change-Id: Id705aab833da546c57950fad115c694b96c5fd24 Reviewed-on: https://chromium-review.googlesource.com/c/1281176 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600037}(cherry picked from commit f5f3e4589bce29e58ca0c2df2285374087881da9) Reviewed-on: https://chromium-review.googlesource.com/c/1293994 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#215} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9b102f4d05e81d8673b5ad284bc734d9d99549d9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBackgroundTask.java [modify] https://crrev.com/9b102f4d05e81d8673b5ad284bc734d9d99549d9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java [modify] https://crrev.com/9b102f4d05e81d8673b5ad284bc734d9d99549d9/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/9b102f4d05e81d8673b5ad284bc734d9d99549d9/chrome/browser/android/explore_sites/explore_sites_service_impl.cc [modify] https://crrev.com/9b102f4d05e81d8673b5ad284bc734d9d99549d9/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814 Commit: 3bbd956ab7375c946dbdb3a8e5d3c1a9ed5fa814 Author: petewil@chromium.org Commiter: petewil@chromium.org Date: 2018-10-22 16:26:25 +0000 UTC [EoS] Site Blacklisting part 3 - Remove sites from the UI. When the user chooses the "remove" item from the long press menu, remove the site from the UI. It is already being removed from the database. Bug: 893845 Change-Id: Icbd8292475983f4c263113043a001d11f3f09521 Reviewed-on: https://chromium-review.googlesource.com/c/1278955 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599438}(cherry picked from commit a564f6e01d3486288673b7f63e679e004108f067) Reviewed-on: https://chromium-review.googlesource.com/c/1294013 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#214} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b102f4d05e81d8673b5ad284bc734d9d99549d9 Commit: 9b102f4d05e81d8673b5ad284bc734d9d99549d9 Author: petewil@chromium.org Commiter: petewil@chromium.org Date: 2018-10-22 16:27:14 +0000 UTC [EoS] Fix the blacklist application Some sites were being added to the blacklist properly, but not filtered out when doing the join against the blacklist table. This happened because the sites in our database did not consistently end with "/", but sometimes a "/" got added before we put the site into the blacklist. The fix here is to pass all sites through GURL and get the spec after parsing, so they will be consistent. Bug: 893845 Change-Id: Id705aab833da546c57950fad115c694b96c5fd24 Reviewed-on: https://chromium-review.googlesource.com/c/1281176 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600037}(cherry picked from commit f5f3e4589bce29e58ca0c2df2285374087881da9) Reviewed-on: https://chromium-review.googlesource.com/c/1293994 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#215} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d29132bf8dc021f7fbb964c7917523971d7af6e8 Commit: d29132bf8dc021f7fbb964c7917523971d7af6e8 Author: petewil@chromium.org Commiter: petewil@chromium.org Date: 2018-10-22 16:25:24 +0000 UTC [EoS] Site blacklisting part 2 Make sure sites in the blacklist are not returned as part of a catalog get operation. This builds upon Site blacklisting part 1. Bug: 893845 Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31 Reviewed-on: https://chromium-review.googlesource.com/c/1274058 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599325}(cherry picked from commit da6c8bfcbd9edb1a2dfa29642124c3b762c05894) Reviewed-on: https://chromium-review.googlesource.com/c/1293993 Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#213} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 30
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 11