ChromeAppModeStart_v4 needs to funnel itself through crash reporter initialization.

ChromeMainDelegate::InitMacCrashReporter() (chrome/app/chrome_main_delegate.cc) is where we normally do this initialization on macOS. That’s called by ChromeMainDelegate::PreSandboxStartup(). I guess ChromeAppModeStart_v4() isn’t coming through ChromeMain() at all?

True, we don't come through ChromeMain.

We are also not a child process -- we are a peer -- we dlopen() chrome, and we establish a mojo connection.

Simply adding the lines
  crash_reporter::SetCrashReporterClient(new ChromeCrashReporterClient);
  crash_reporter::InitializeCrashpad(true /* initial_client */, "" /* process_type */);
seems to not crash at least. Not sure it actually sets things up appropriately. If I set process_type to something like "appshim" then it's not happy.

Is there any sort of testing I can do to see if that works? IIUC, this would report all appshim crashes as browser crashes (which we would want to differentiate somehow).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c9f89a06fba506b4efdb40fa3407976012a550a

commit 1c9f89a06fba506b4efdb40fa3407976012a550a
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Dec 11 19:46:25 2018

Initialize Crashpad to catch app shim crashes.

Bug:  893821 
Change-Id: Ic2ff92577d35250fbe773ff6b80918da33d57155
Reviewed-on: https://chromium-review.googlesource.com/c/1365955
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615629}
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app/chrome_crash_reporter_client.h
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app_shim/BUILD.gn
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app_shim/DEPS
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/app_shim/chrome_main_app_mode_mac.mm
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/chrome/test/base/chrome_test_launcher.cc
[modify] https://crrev.com/1c9f89a06fba506b4efdb40fa3407976012a550a/components/crash/content/app/crashpad.cc

Should be all set, setting a reminder to verify.

The NextAction date has arrived: 2018-12-13