New issue
Advanced search Search tips

Issue 893779 link

Starred by 1 user
Status: Fixed
Owner:
minch@chromium.org
Closed: Oct 10
Cc:
omrilio@chromium.org
x...@chromium.org
mccanny@chromium.org
kejiashao@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dragged window should not be dropped into overview if preview area is shown

Project Member Reported by minch@chromium.org, Oct 9 
What steps will reproduce the problem?
(1) Drag a window from top into drag indicators to show preview area.
(2) And also inside drop target.

What is the expected result?
Dragged window should still go to be snapped.

What happens instead?
Dragged window being dropped into overview.

Drop target has some overlap with preview area and it only be set to non-visible when preview area is shown.
If we dragged a window into drop target and also triggered the preview area, the window will be dropped into overview instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c60ed9089a196e8decd08c149b36d9b0fcd66d

commit b2c60ed9089a196e8decd08c149b36d9b0fcd66d
Author: Min Chen <minch@google.com>
Date: Wed Oct 10 17:58:55 2018

Snap dragged window when preview area is shown.

Moved the logic that determine whether the dragged window is inside
the new selector item from WindowGrid to TabletModeWindowDragDelegate.
And do not add the dragged window into overview even if it is inside
the new selector item but preview area is shown.

Bug:  893779 
Change-Id: Idb41eefb62f0c1ddd0ccea8b8edef4070b07bb38
Reviewed-on: https://chromium-review.googlesource.com/c/1272448
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598394}
[modify] https://crrev.com/b2c60ed9089a196e8decd08c149b36d9b0fcd66d/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/b2c60ed9089a196e8decd08c149b36d9b0fcd66d/ash/wm/overview/window_grid.h
[modify] https://crrev.com/b2c60ed9089a196e8decd08c149b36d9b0fcd66d/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/b2c60ed9089a196e8decd08c149b36d9b0fcd66d/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
[modify] https://crrev.com/b2c60ed9089a196e8decd08c149b36d9b0fcd66d/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h

Comment 2 by minch@chromium.org, Oct 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment