Issue metadata
Sign in to add a comment
|
43% regression in loading.desktop at 595645:595726 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 9
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16d4b832e40000
,
Oct 10
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16d4b832e40000 Only flush tokenized chunks to the HTML parser for valid script types. by acomminos@fb.com https://chromium.googlesource.com/chromium/src/+/174813503285a1ff88efe4fcb8775df6663fa371 timeToFirstContentfulPaint: 62.49 → 135.2 (+72.68) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/loading-benchmarks
,
Oct 10
,
Oct 10
Issue 893824 has been merged into this issue.
,
Oct 15
,
Oct 15
Issue 891391 has been merged into this issue.
,
Oct 15
Reposting from merged issues: I've noticed that both The Verge and Naver (sites which regress with this revision), frequently use invalid script types in their bodies for templating: `<script type="text/template-dynamic" style="display: none;">` I suspect that parser throughput has gone up by skipping the yield, but the render latency has increased as well due to the lack of flush points. I'm doubtful how meaningful the earlier paints are- as the first paint prior to this revision likely occurred during the yield after parsing the no-op script tags used for templating, much of the templated DOM content would not be visible yet. I'm going to go ahead and analyze screenshots of the first contentful paint before and after the blamed rev. FWIW, load_avg is unaffected. Additionally, there appear to be memory usage wins on Taobao (which also uses templating script tags): https://chromeperf.appspot.com/group_report?rev=595719.
,
Oct 16
Issue 893835 has been merged into this issue. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 9