Make MagicTether backwards compatible |
|||||||||||
Issue descriptionWe are about to turn on the multidevice flags in 71 by default. In the current state, if we do that, any users whose phones either haven't gotten the GmsCore apk or flag rollout, or haven't had their phones do a CryptAuth enrollment *after* that rollout will be stuck with both of these features broken and no way to re-enable them. Note that this is only likely to affect dev and beta users since the rollout should be done by the time 71 ramps up on stable. However, my main concern with this issue is the noise that user feedback will create from this breaking change and the triaging burden we'll incur in needing to look at every report to determine whether the user is stuck in this state. If we can avoid that problem altogether, I'd like to try. I'm going to investigate.
,
Oct 11
Josh is taking the easyunlock side of this while I work on the Tethering half. Josh, I've uploaded my WIP CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1277272. I just need to fix a few more tests :-).
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587 commit 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587 Author: Jeremy Klein <jlklein@google.com> Date: Fri Oct 12 01:26:45 2018 Make Instant Tethering work with legacy hosts before hosts update. The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking Instant Tethering in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting INSTANT_TETHER_HOST support. In this scenario, the only possiblity is that this host device has not reenrolled yet after receiving the new flags. Bug: 893769 Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d Reviewed-on: https://chromium-review.googlesource.com/c/1277272 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599058} [modify] https://crrev.com/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587/chrome/browser/chromeos/tether/tether_service_unittest.cc [modify] https://crrev.com/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587/chromeos/components/tether/tether_host_fetcher_impl.cc [modify] https://crrev.com/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587/chromeos/components/tether/tether_host_fetcher_impl.h [modify] https://crrev.com/1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53926116c29a39fac23b9e6c94394ef428dfc904 commit 53926116c29a39fac23b9e6c94394ef428dfc904 Author: Jeremy Klein <jlklein@chromium.org> Date: Fri Oct 12 14:46:50 2018 Revert "Make Instant Tethering work with legacy hosts before hosts update." This reverts commit 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587. Reason for revert: Breaks tests when combined with https://chromium-review.googlesource.com/c/chromium/src/+/1260491. Doesn't properly wait for devicesync service to be ready before querying the list of devices. Original change's description: > Make Instant Tethering work with legacy hosts before hosts update. > > The phone side flags and enrollment will be slower than the ChromeOS > rollout. In order to avoid breaking Instant Tethering in the meantime, > look for cases where: > > 1) There are no host devices reporting BETTER_TOGETHER_HOST support. > 2) There is at least one host device reporting INSTANT_TETHER_HOST > support. > > In this scenario, the only possiblity is that this host device has not > reenrolled yet after receiving the new flags. > > Bug: 893769 > Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d > Reviewed-on: https://chromium-review.googlesource.com/c/1277272 > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599058} TBR=khorimoto@chromium.org,jlklein@chromium.org Change-Id: Iee7a71e551e875764f38cdf72391378cdacc80bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893769 Reviewed-on: https://chromium-review.googlesource.com/c/1278541 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599208} [modify] https://crrev.com/53926116c29a39fac23b9e6c94394ef428dfc904/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/53926116c29a39fac23b9e6c94394ef428dfc904/chrome/browser/chromeos/tether/tether_service_unittest.cc [modify] https://crrev.com/53926116c29a39fac23b9e6c94394ef428dfc904/chromeos/components/tether/tether_host_fetcher_impl.cc [modify] https://crrev.com/53926116c29a39fac23b9e6c94394ef428dfc904/chromeos/components/tether/tether_host_fetcher_impl.h [modify] https://crrev.com/53926116c29a39fac23b9e6c94394ef428dfc904/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
,
Oct 15
,
Oct 15
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30d5a4ef08748d8639b8fe00eb2fef8c00023256 commit 30d5a4ef08748d8639b8fe00eb2fef8c00023256 Author: Jeremy Klein <jlklein@google.com> Date: Tue Oct 16 19:19:44 2018 Reland "Make Instant Tethering work with legacy hosts before hosts update." This is a reland of 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587 Now correctly waiting for DeviceSyncClient to be ready. Original change's description: > Make Instant Tethering work with legacy hosts before hosts update. > > The phone side flags and enrollment will be slower than the ChromeOS > rollout. In order to avoid breaking Instant Tethering in the meantime, > look for cases where: > > 1) There are no host devices reporting BETTER_TOGETHER_HOST support. > 2) There is at least one host device reporting INSTANT_TETHER_HOST > support. > > In this scenario, the only possiblity is that this host device has not > reenrolled yet after receiving the new flags. > > Bug: 893769 > Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d > Reviewed-on: https://chromium-review.googlesource.com/c/1277272 > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599058} Bug: 893769 Change-Id: I89aff002fe1235f08aa690ef7f8374aa4100e858 Reviewed-on: https://chromium-review.googlesource.com/c/1278542 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#600074} [modify] https://crrev.com/30d5a4ef08748d8639b8fe00eb2fef8c00023256/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/30d5a4ef08748d8639b8fe00eb2fef8c00023256/chrome/browser/chromeos/tether/tether_service_unittest.cc [modify] https://crrev.com/30d5a4ef08748d8639b8fe00eb2fef8c00023256/chromeos/components/tether/tether_host_fetcher_impl.cc [modify] https://crrev.com/30d5a4ef08748d8639b8fe00eb2fef8c00023256/chromeos/components/tether/tether_host_fetcher_impl.h [modify] https://crrev.com/30d5a4ef08748d8639b8fe00eb2fef8c00023256/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
,
Oct 16
,
Oct 17
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
,
Oct 18
Has this been thoroughly tested? Not seeing comments re: verifying the fix....
,
Oct 18
Hey Kevin - yep I manually verified this fix by testing Magic Tether both with and without a phone that supports our new flow, as well as an account with both a legacy device and new device. Everything seems to be working correctly.
,
Oct 18
Approving merge to M71 Chrome OS.
,
Oct 18
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29857a7608b9ccde3d298f0b2f2e6ec261d423ca commit 29857a7608b9ccde3d298f0b2f2e6ec261d423ca Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Oct 18 18:51:45 2018 Reland "Make Instant Tethering work with legacy hosts before hosts update." This is a reland of 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587 Now correctly waiting for DeviceSyncClient to be ready. Original change's description: > Make Instant Tethering work with legacy hosts before hosts update. > > The phone side flags and enrollment will be slower than the ChromeOS > rollout. In order to avoid breaking Instant Tethering in the meantime, > look for cases where: > > 1) There are no host devices reporting BETTER_TOGETHER_HOST support. > 2) There is at least one host device reporting INSTANT_TETHER_HOST > support. > > In this scenario, the only possiblity is that this host device has not > reenrolled yet after receiving the new flags. > > Bug: 893769 > Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d > Reviewed-on: https://chromium-review.googlesource.com/c/1277272 > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599058} TBR=jlklein@google.com (cherry picked from commit 30d5a4ef08748d8639b8fe00eb2fef8c00023256) Bug: 893769 Change-Id: I89aff002fe1235f08aa690ef7f8374aa4100e858 Reviewed-on: https://chromium-review.googlesource.com/c/1278542 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600074} Reviewed-on: https://chromium-review.googlesource.com/c/1289301 Cr-Commit-Position: refs/branch-heads/3578@{#130} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/29857a7608b9ccde3d298f0b2f2e6ec261d423ca/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/29857a7608b9ccde3d298f0b2f2e6ec261d423ca/chrome/browser/chromeos/tether/tether_service_unittest.cc [modify] https://crrev.com/29857a7608b9ccde3d298f0b2f2e6ec261d423ca/chromeos/components/tether/tether_host_fetcher_impl.cc [modify] https://crrev.com/29857a7608b9ccde3d298f0b2f2e6ec261d423ca/chromeos/components/tether/tether_host_fetcher_impl.h [modify] https://crrev.com/29857a7608b9ccde3d298f0b2f2e6ec261d423ca/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29857a7608b9ccde3d298f0b2f2e6ec261d423ca Commit: 29857a7608b9ccde3d298f0b2f2e6ec261d423ca Author: khorimoto@google.com Commiter: khorimoto@chromium.org Date: 2018-10-18 18:51:45 +0000 UTC Reland "Make Instant Tethering work with legacy hosts before hosts update." This is a reland of 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587 Now correctly waiting for DeviceSyncClient to be ready. Original change's description: > Make Instant Tethering work with legacy hosts before hosts update. > > The phone side flags and enrollment will be slower than the ChromeOS > rollout. In order to avoid breaking Instant Tethering in the meantime, > look for cases where: > > 1) There are no host devices reporting BETTER_TOGETHER_HOST support. > 2) There is at least one host device reporting INSTANT_TETHER_HOST > support. > > In this scenario, the only possiblity is that this host device has not > reenrolled yet after receiving the new flags. > > Bug: 893769 > Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d > Reviewed-on: https://chromium-review.googlesource.com/c/1277272 > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599058} TBR=jlklein@google.com (cherry picked from commit 30d5a4ef08748d8639b8fe00eb2fef8c00023256) Bug: 893769 Change-Id: I89aff002fe1235f08aa690ef7f8374aa4100e858 Reviewed-on: https://chromium-review.googlesource.com/c/1278542 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600074} Reviewed-on: https://chromium-review.googlesource.com/c/1289301 Cr-Commit-Position: refs/branch-heads/3578@{#130} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 23
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jlklein@chromium.org
, Oct 9