Need to persist mode changing UI in the keyboard when in password fields |
|||||||||||
Issue description* Today, we remove the mode change UI for password inputs (floating/dock etc). Yet, the keyboard inherits the previous configuration. Which means you can use anyone you want, but you can't easily switch. This is silly. * More, when you have a password field that does "show password", it changes to an input field, which switches the mode of the keyboard. Unexpected/not great (see screencast). * Note: we use the space for the mode change UI to show numbers. This is great. We should keep this for password input. https://drive.google.com/open?id=1LICIyb_JMdCS5tPY74pYSi7FpAJ2wKfa
,
Oct 10
,
Oct 11
,
Oct 16
In android platform, there are context type called "visible password" type. When user make the password text box visible, OS also need to extension the current input box is "password" other than "normal" input box. We need fix the bug chrome os side. shuchen@ Is the context type is calculated by IMF?
,
Oct 16
Testing out Chrome-on-Android Gboard using Gmail, it works even when visible password is selected. Here is the element, and the only thing that changes is the type="password" becomes type="text". <input type="password" class="whsOnd zHQkBf" jsname="YPqjbf" autocomplete="current-password" spellcheck="false" tabindex="0" aria-label="Enter your password" name="password" autocapitalize="off" autocorrect="off" dir="ltr" data-initial-dir="ltr" data-initial-value=""> I suspect that either Chrome is keying off of name="password" or some combination of the other classes like autocapitalize and autocorrect both off. I've reached out to the Chrome team to find out what they recommend. My feeling is we should just adopt the same logic so at least we are consistent.
,
Oct 16
Hi all, the Chrome Password Manager handles these state transitions: https://crbug.com/794949 HTH Patrick, PM Chrome Password Manager
,
Oct 17
Hi Yuichiro, Do you have ideas about how Android IMF knows about the element is a password (visible) element? <input type="text" class="whsOnd zHQkBf" jsname="YPqjbf" autocomplete="current-password" spellcheck="false" tabindex="0" aria-label="Enter your password" name="password" autocapitalize="off" autocorrect="off" dir="ltr" data-initial-dir="ltr" data-initial-value="asdf" badinput="false"> And does ARC++ support the "visible password" type? Thanks.
,
Oct 17
Already got a clue, assigning back to myself. Refers to https://chromium-review.googlesource.com/c/chromium/src/+/827075.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12d71af964751dcde9f4bb12266012f2d940e711 commit 12d71af964751dcde9f4bb12266012f2d940e711 Author: Shu Chen <shuchen@google.com> Date: Fri Oct 19 01:04:23 2018 Makes chrome.inputMethodPrivate.onFocus event to carry |hasBeenPassword| info. Bug: 893761 Change-Id: Ia90c742402dca369847c22aa91c037c45fb92edd Reviewed-on: https://chromium-review.googlesource.com/c/1288500 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601005} [modify] https://crrev.com/12d71af964751dcde9f4bb12266012f2d940e711/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc [modify] https://crrev.com/12d71af964751dcde9f4bb12266012f2d940e711/chrome/common/extensions/api/input_method_private.json [modify] https://crrev.com/12d71af964751dcde9f4bb12266012f2d940e711/ui/base/ime/text_input_flags.h
,
Oct 19
Over to Yingbing to do the extension side changes.
Yingbing, chrome.inputMethodPrivate.onFocus event will carry the additional info about whether the input context has been password before. Please refer to this code sample:
chrome.inputMethodPrivate.onFocus.addListener((context) => {
let type = context.type;
let hasBeenPassword = context.hasBeenPassword;
...
});
,
Oct 19
,
Oct 19
,
Oct 23
,
Oct 23
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/1208786365d8eca616e5e4fb28cb712f615683ec commit 1208786365d8eca616e5e4fb28cb712f615683ec Author: David Vallet <dvallet@google.com> Date: Tue Oct 23 04:41:18 2018
,
Oct 24
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/273c5e92b7bfd8063df8381d5f6c8318ad40cc53 commit 273c5e92b7bfd8063df8381d5f6c8318ad40cc53 Author: David Vallet <dvallet@google.com> Date: Wed Oct 24 23:23:12 2018
,
Oct 25
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/e1cce2302c03971af82417993d370177d71a75d9 commit e1cce2302c03971af82417993d370177d71a75d9 Author: Nicolas Norvez <norvez@google.com> Date: Thu Oct 25 20:48:11 2018
,
Oct 25
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/561a1fb0c5390f21fabea44f54058f052801e7ff commit 561a1fb0c5390f21fabea44f54058f052801e7ff Author: Leo Zhang <googleo@google.com> Date: Thu Oct 25 21:17:43 2018
,
Nov 12
Issue 760470 has been merged into this issue.
,
Nov 12
Issue 760474 has been merged into this issue. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by pcovell@chromium.org
, Oct 9